You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/10/14 12:48:41 UTC

[GitHub] [spark] maropu commented on pull request #29982: [SPARK-33100][SQL] Ignore a semicolon inside a bracketed comment in spark-sql

maropu commented on pull request #29982:
URL: https://github.com/apache/spark/pull/29982#issuecomment-708379192


   > So, I recommend to save this variable.
   
   For example, I thought it like this (this approach also can pass the added test in this PR): https://github.com/maropu/spark/commit/d9c256ad32b5ad5bce419d1eed0e42ff764c3b4c
   Probably, we need more tests for better branch coverage, e.g., the case you described in https://github.com/apache/spark/pull/29982#discussion_r503948938, bracketed comments having meta chars, multi-line bracketed comments, brabrabra....


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org