[jira] [Commented] (SOLR-5098) Add REST support for adding field types to the schema

["Steve Rowe (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SOLR-5098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14110835#comment-14110835 ] 

Steve Rowe commented on SOLR-5098:
----------------------------------

Tim, looks great - I did a quick review and noticed a few things:

# {{ManagedIndexSchema}}, the {{addFieldType()}}, {{addFieldTypes()}} and {{newFieldType()}} methods should extend (no-op) methods in {{IndexSchema}}, like the {{addField()}}, {{addFields()}} and {{newField()}} methods do.
# Multi-term analyzers aren't handled in {{ManagedIndexSchema.addFieldTypes()}} - you have to cast to {{TextField}} to access this analyzer if it's defined.
# It's a little weird that {{FieldTypeCollectionResource.addOrUpdateFieldTypes()}} calls {{FieldTypeResource.addNewFieldTypes()}} - that piece of code is fairly small, converting {{addNewFieldTypes()}} to specialized non-statics might be better?
# {{FieldTypeCollectionResource}} should implement {{POSTable}}, and {{FieldTypeResource}} should implement {{PUTable}}.
# The licence text in {{TestManagedSchemaFieldTypeResource}} is a copy-paste of the one in {{TestFieldTypeResource}}, where I added spaces where they don't belong on the last line: "limit     ations".
# In addition to testing creation of field types, {{TestManagedSchemaFieldTypeResource}} should also test creating fields using newly created field types.
# {{TestCloudManagedSchemaConcurrent}} should be modified to include some field type additions; this class will need some love every time we add new functionality to the schema API.

> Add REST support for adding field types to the schema
> -----------------------------------------------------
>
>                 Key: SOLR-5098
>                 URL: https://issues.apache.org/jira/browse/SOLR-5098
>             Project: Solr
>          Issue Type: Sub-task
>          Components: Schema and Analysis
>            Reporter: Steve Rowe
>            Assignee: Timothy Potter
>            Priority: Minor
>         Attachments: SOLR-5098.patch, SOLR-5098.patch
>
>
> POST to {{/schema/fieldtypes}} will add one or more new field types to the schema.
> PUT to {{/schema/fieldtypes/_name_}} will add the {{_name_}}'d field type to the schema.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org