You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2019/12/20 15:21:20 UTC
[GitHub] [nifi-minifi-cpp] bakaid opened a new pull request #702:
MINIFICPP-1091 - Update LICENSE and NOTICE
bakaid opened a new pull request #702: MINIFICPP-1091 - Update LICENSE and NOTICE
URL: https://github.com/apache/nifi-minifi-cpp/pull/702
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file?
- [ ] If applicable, have you updated the NOTICE file?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [nifi-minifi-cpp] arpadboda commented on a change in pull request
#702: MINIFICPP-1091 - Update LICENSE and NOTICE
Posted by GitBox <gi...@apache.org>.
arpadboda commented on a change in pull request #702: MINIFICPP-1091 - Update LICENSE and NOTICE
URL: https://github.com/apache/nifi-minifi-cpp/pull/702#discussion_r363245358
##########
File path: LICENSE
##########
@@ -203,6 +203,12 @@
APACHE NIFI - MINIFI SUBCOMPONENTS:
+The Apache NiFi - MiNiFi project contains subcomponents licensed under the Apache License, Version 2.0:
Review comment:
I know it's just moved, but my gut feeling says that we should call the project MiNiFi C++ here as well to distinguish cpp and java versions.
@apiri what's your opinion?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [nifi-minifi-cpp] bakaid commented on a change in pull request
#702: MINIFICPP-1091 - Update LICENSE and NOTICE
Posted by GitBox <gi...@apache.org>.
bakaid commented on a change in pull request #702: MINIFICPP-1091 - Update LICENSE and NOTICE
URL: https://github.com/apache/nifi-minifi-cpp/pull/702#discussion_r363221025
##########
File path: LICENSE
##########
@@ -2531,3 +2531,101 @@ This product bundles 'zlib' within 'OpenCV' under the following license:
The data format used by the zlib library is described by RFCs (Request for
Comments) 1950 to 1952 in the files http://tools.ietf.org/html/rfc1950
(zlib format), rfc1951 (deflate format) and rfc1952 (gzip format).
+
+This product bundles 'TinyXml2' within 'AWS SDK for C++' under a zlib license:
+
+Original code by Lee Thomason (www.grinninglizard.com)
+
+This software is provided 'as-is', without any express or implied
+warranty. In no event will the authors be held liable for any
+damages arising from the use of this software.
+
+Permission is granted to anyone to use this software for any
+purpose, including commercial applications, and to alter it and
+redistribute it freely, subject to the following restrictions:
+
+1. The origin of this software must not be misrepresented; you must
+not claim that you wrote the original software. If you use this
+software in a product, an acknowledgment in the product documentation
+would be appreciated but is not required.
+
+2. Altered source versions must be plainly marked as such, and
+must not be misrepresented as being the original software.
+
+3. This notice may not be removed or altered from any source
+distribution.
+
+
+This product bundles 'cJSON' within 'AWS SDK for C++' under an MIT license:
+
+Copyright (c) 2009-2017 Dave Gamble and cJSON contributors
+
+Permission is hereby granted, free of charge, to any person obtaining a copy
+of this software and associated documentation files (the "Software"), to deal
+in the Software without restriction, including without limitation the rights
+to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+copies of the Software, and to permit persons to whom the Software is
+furnished to do so, subject to the following conditions:
+
+The above copyright notice and this permission notice shall be included in
+all copies or substantial portions of the Software.
+
+THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
+THE SOFTWARE.
+
+
+This product bundles 'OpenSSL build files for cmake used for Android Builds' within 'AWS SDK for C++' under an MIT license:
+
+Based on original work by David Manura
+Copyright (C) 2007-2012 LuaDist.
+Copyright (C) 2013 Brian Sidebotham
+
+Redistribution and use of this file is allowed according to the terms of the
+MIT license.
+
+Permission is hereby granted, free of charge, to any person obtaining a copy
+of this software and associated documentation files (the "Software"), to deal
+in the Software without restriction, including without limitation the rights
+to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+copies of the Software, and to permit persons to whom the Software is
+furnished to do so, subject to the following conditions:
+
+The above copyright notice and this permission notice shall be included in all
+copies or substantial portions of the Software.
+
+THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
+SOFTWARE.
+
+
+This product bundles 'Android tool chain cmake build files' within 'AWS SDK for C++' under an MIT license:
Review comment:
There is no explicit license file for this in the aws-sdk-cpp repo, just a mention in https://github.com/aws/aws-sdk-cpp/blob/66666d9437429c28927576cb5c898e490f8c8cf9/LICENSE.txt#L57 that it is an MIT license and the copyright holders, so I have added an MIT license here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [nifi-minifi-cpp] asfgit closed pull request #702: MINIFICPP-1091 -
Update LICENSE and NOTICE
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #702: MINIFICPP-1091 - Update LICENSE and NOTICE
URL: https://github.com/apache/nifi-minifi-cpp/pull/702
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [nifi-minifi-cpp] apiri commented on a change in pull request #702:
MINIFICPP-1091 - Update LICENSE and NOTICE
Posted by GitBox <gi...@apache.org>.
apiri commented on a change in pull request #702: MINIFICPP-1091 - Update LICENSE and NOTICE
URL: https://github.com/apache/nifi-minifi-cpp/pull/702#discussion_r363389173
##########
File path: LICENSE
##########
@@ -203,6 +203,12 @@
APACHE NIFI - MINIFI SUBCOMPONENTS:
+The Apache NiFi - MiNiFi project contains subcomponents licensed under the Apache License, Version 2.0:
Review comment:
yeah, that seems fair. it was originally done as such from the standpoint that it was under a common effort/subproject but for licensing clarity, clearly differentiating will be helpful
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [nifi-minifi-cpp] apiri commented on a change in pull request #702:
MINIFICPP-1091 - Update LICENSE and NOTICE
Posted by GitBox <gi...@apache.org>.
apiri commented on a change in pull request #702: MINIFICPP-1091 - Update LICENSE and NOTICE
URL: https://github.com/apache/nifi-minifi-cpp/pull/702#discussion_r363395242
##########
File path: LICENSE
##########
@@ -1793,3 +1620,1012 @@ ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY,
OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT
OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
SUCH DAMAGE.
+
+This product bundles 'libcoap' which is available under a 2-clause BSD license:
+
+Copyright (c) 2010--2019, Olaf Bergmann and others
+All rights reserved.
+
+Redistribution and use in source and binary forms, with or without
+modification, are permitted provided that the following conditions are
+met:
+
+ o Redistributions of source code must retain the above copyright
+ notice, this list of conditions and the following disclaimer.
+
+ o Redistributions in binary form must reproduce the above copyright
+ notice, this list of conditions and the following disclaimer in
+ the documentation and/or other materials provided with the
+ distribution.
+
+THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+"AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
+A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
+HOLDER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
+SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
+LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
+DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
+THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+(INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+
+========================================================================
+getopt.c
+
+License information for getopt.c. This file is only used on Windows
+builds of the executables in the examples folder:
+
+/*
+ * This file was copied from the following newsgroup posting:
+ *
+ * Newsgroups: mod.std.unix
+ * Subject: public domain AT&T getopt source
+ * Date: 3 Nov 85 19:34:15 GMT
+ *
+ * Here's something you've all been waiting for: the AT&T public domain
+ * source for getopt(3). It is the code which was given out at the 1985
+ * UNIFORUM conference in Dallas. I obtained it by electronic mail
+ * directly from AT&T. The people there assure me that it is indeed
+ * in the public domain.
+ */
+
+========================================================================
+OpenSSL
+
+Binaries that are linked against OpenSSL include software developed
+by the OpenSSL Project for use in the OpenSSL Toolkit.
+(http://www.openssl.org/). Please consult the OpenSSL license
+(https://www.openssl.org/source/license.html) for licensing terms.
+
+========================================================================
+GnuTLS
+
+When compiled with GnuTLS support, this software includes components
+that are licensed under the terms of the the GNU Lesser General Public
+License, version 2.1
+(https://www.gnu.org/licenses/old-licenses/lgpl-2.1.html).
+
+========================================================================
+tinyDTLS
+
+When compiled with tinyDTLS support, this software includes components
+that are licensed under the terms of the Eclipse Distribution License 1.0
+(http://www.eclipse.org/org/documents/edl-v10.php).
+
+This project bundles 'open62541' which is available under an MPLv2.0 license,
Review comment:
It is my understanding this is a binary inclusion. We should be explicit about that fact as it is a weak copyleft license and its use outside of that capacity would not be okay. I see the conditional nature of it is highlighted in the README, but we should be also update the language here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [nifi-minifi-cpp] bakaid commented on a change in pull request
#702: MINIFICPP-1091 - Update LICENSE and NOTICE
Posted by GitBox <gi...@apache.org>.
bakaid commented on a change in pull request #702: MINIFICPP-1091 - Update LICENSE and NOTICE
URL: https://github.com/apache/nifi-minifi-cpp/pull/702#discussion_r363220637
##########
File path: LICENSE
##########
@@ -2531,3 +2531,101 @@ This product bundles 'zlib' within 'OpenCV' under the following license:
The data format used by the zlib library is described by RFCs (Request for
Comments) 1950 to 1952 in the files http://tools.ietf.org/html/rfc1950
(zlib format), rfc1951 (deflate format) and rfc1952 (gzip format).
+
+This product bundles 'TinyXml2' within 'AWS SDK for C++' under a zlib license:
+
+Original code by Lee Thomason (www.grinninglizard.com)
+
+This software is provided 'as-is', without any express or implied
+warranty. In no event will the authors be held liable for any
+damages arising from the use of this software.
+
+Permission is granted to anyone to use this software for any
+purpose, including commercial applications, and to alter it and
+redistribute it freely, subject to the following restrictions:
+
+1. The origin of this software must not be misrepresented; you must
+not claim that you wrote the original software. If you use this
+software in a product, an acknowledgment in the product documentation
+would be appreciated but is not required.
+
+2. Altered source versions must be plainly marked as such, and
+must not be misrepresented as being the original software.
+
+3. This notice may not be removed or altered from any source
+distribution.
+
+
+This product bundles 'cJSON' within 'AWS SDK for C++' under an MIT license:
Review comment:
The `NOTICE.txt` of aws-sdk-cpp says that they bundle JsonCpp, but this is no longer true, as evidenced by the code and the `1.5.0` part of https://github.com/aws/aws-sdk-cpp/blob/master/CHANGELOG.md
They now bundle cJSON, so I have included the license for that here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [nifi-minifi-cpp] bakaid commented on a change in pull request
#702: MINIFICPP-1091 - Update LICENSE and NOTICE
Posted by GitBox <gi...@apache.org>.
bakaid commented on a change in pull request #702: MINIFICPP-1091 - Update LICENSE and NOTICE
URL: https://github.com/apache/nifi-minifi-cpp/pull/702#discussion_r363398426
##########
File path: LICENSE
##########
@@ -203,6 +203,12 @@
APACHE NIFI - MINIFI SUBCOMPONENTS:
+The Apache NiFi - MiNiFi project contains subcomponents licensed under the Apache License, Version 2.0:
Review comment:
Agreed, will update all instances.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [nifi-minifi-cpp] bakaid commented on a change in pull request
#702: MINIFICPP-1091 - Update LICENSE and NOTICE
Posted by GitBox <gi...@apache.org>.
bakaid commented on a change in pull request #702: MINIFICPP-1091 - Update LICENSE and NOTICE
URL: https://github.com/apache/nifi-minifi-cpp/pull/702#discussion_r363398867
##########
File path: LICENSE
##########
@@ -1793,3 +1620,1012 @@ ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY,
OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT
OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
SUCH DAMAGE.
+
+This product bundles 'libcoap' which is available under a 2-clause BSD license:
+
+Copyright (c) 2010--2019, Olaf Bergmann and others
+All rights reserved.
+
+Redistribution and use in source and binary forms, with or without
+modification, are permitted provided that the following conditions are
+met:
+
+ o Redistributions of source code must retain the above copyright
+ notice, this list of conditions and the following disclaimer.
+
+ o Redistributions in binary form must reproduce the above copyright
+ notice, this list of conditions and the following disclaimer in
+ the documentation and/or other materials provided with the
+ distribution.
+
+THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+"AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
+A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
+HOLDER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
+SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
+LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
+DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
+THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+(INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+
+========================================================================
+getopt.c
+
+License information for getopt.c. This file is only used on Windows
+builds of the executables in the examples folder:
+
+/*
+ * This file was copied from the following newsgroup posting:
+ *
+ * Newsgroups: mod.std.unix
+ * Subject: public domain AT&T getopt source
+ * Date: 3 Nov 85 19:34:15 GMT
+ *
+ * Here's something you've all been waiting for: the AT&T public domain
+ * source for getopt(3). It is the code which was given out at the 1985
+ * UNIFORUM conference in Dallas. I obtained it by electronic mail
+ * directly from AT&T. The people there assure me that it is indeed
+ * in the public domain.
+ */
+
+========================================================================
+OpenSSL
+
+Binaries that are linked against OpenSSL include software developed
+by the OpenSSL Project for use in the OpenSSL Toolkit.
+(http://www.openssl.org/). Please consult the OpenSSL license
+(https://www.openssl.org/source/license.html) for licensing terms.
+
+========================================================================
+GnuTLS
+
+When compiled with GnuTLS support, this software includes components
+that are licensed under the terms of the the GNU Lesser General Public
+License, version 2.1
+(https://www.gnu.org/licenses/old-licenses/lgpl-2.1.html).
+
+========================================================================
+tinyDTLS
+
+When compiled with tinyDTLS support, this software includes components
+that are licensed under the terms of the Eclipse Distribution License 1.0
+(http://www.eclipse.org/org/documents/edl-v10.php).
+
+This project bundles 'open62541' which is available under an MPLv2.0 license,
Review comment:
Yep, it is a binary-only inclusion, will update the language to reflect this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [nifi-minifi-cpp] bakaid commented on issue #702: MINIFICPP-1091 -
Update LICENSE and NOTICE
Posted by GitBox <gi...@apache.org>.
bakaid commented on issue #702: MINIFICPP-1091 - Update LICENSE and NOTICE
URL: https://github.com/apache/nifi-minifi-cpp/pull/702#issuecomment-571235830
@apiri @arpadboda thanks for the reviews, addressed the review comments in a new commit.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [nifi-minifi-cpp] apiri commented on issue #702: MINIFICPP-1091 -
Update LICENSE and NOTICE
Posted by GitBox <gi...@apache.org>.
apiri commented on issue #702: MINIFICPP-1091 - Update LICENSE and NOTICE
URL: https://github.com/apache/nifi-minifi-cpp/pull/702#issuecomment-571221571
reviewing
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services