You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by GitBox <gi...@apache.org> on 2022/02/11 00:34:23 UTC

[GitHub] [trafficserver] bryancall opened a new pull request #8665: Fixed issues when compiling with -Og

bryancall opened a new pull request #8665:
URL: https://github.com/apache/trafficserver/pull/8665


   abi-dumper likes to have binaries compiled with -Og for better testing of binary compatibility.
   
   https://github.com/lvc/abi-dumper


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [trafficserver] bryancall merged pull request #8665: Fixed issues when compiling with -Og

Posted by GitBox <gi...@apache.org>.
bryancall merged pull request #8665:
URL: https://github.com/apache/trafficserver/pull/8665


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [trafficserver] masaori335 commented on a change in pull request #8665: Fixed issues when compiling with -Og

Posted by GitBox <gi...@apache.org>.
masaori335 commented on a change in pull request #8665:
URL: https://github.com/apache/trafficserver/pull/8665#discussion_r804276827



##########
File path: proxy/http2/HTTP2.cc
##########
@@ -606,7 +606,7 @@ http2_convert_header_from_1_1_to_2(HTTPHdr *headers)
 
     // :path
     if (MIMEField *field = headers->field_find(HTTP2_VALUE_PATH, HTTP2_LEN_PATH); field != nullptr) {
-      int value_len;
+      int value_len     = 0;

Review comment:
       It's pretty interesting that line 589 above is almost the same situation but doesn't need initialization.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [trafficserver] bryancall merged pull request #8665: Fixed issues when compiling with -Og

Posted by GitBox <gi...@apache.org>.
bryancall merged pull request #8665:
URL: https://github.com/apache/trafficserver/pull/8665


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org