You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2022/01/26 14:07:35 UTC
[GitHub] [maven-plugin-tools] cstamas opened a new pull request #66: Reshuffle plugin dependencies
cstamas opened a new pull request #66:
URL: https://github.com/apache/maven-plugin-tools/pull/66
Changes:
* use m-p-p 3.6.4 finally, so maven bits can be provided scope
* maven-reporting-impl is optional (so in case standalone mojo is used, it needs to be added to plugin dep)
* align use of reporting and doxia across modules (there were several versions used)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-plugin-tools] slawekjaranowski commented on a change in pull request #66: [MPLUGIN-388] Make reporting dependency optional
Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on a change in pull request #66:
URL: https://github.com/apache/maven-plugin-tools/pull/66#discussion_r793338571
##########
File path: maven-plugin-plugin/pom.xml
##########
@@ -296,7 +276,7 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-plugin-plugin</artifactId>
- <version>3.6.0</version><!-- cannot use ${mavenPluginToolsVersion} property because release plugin would try to update -->
Review comment:
is it not valid?
will work during release?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-plugin-tools] cstamas commented on pull request #66: Reshuffle plugin dependencies
Posted by GitBox <gi...@apache.org>.
cstamas commented on pull request #66:
URL: https://github.com/apache/maven-plugin-tools/pull/66#issuecomment-1022232173
> ATTENTION: Reporting plugin cannot have dependencies in the POM. I tripped over it recently.
? No, this is build/plugins/m-p-p plugin is that needs dep added IF you plan to use PluginReport mojo "standalone"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-plugin-tools] cstamas commented on a change in pull request #66: [MPLUGIN-388] Make reporting dependency optional
Posted by GitBox <gi...@apache.org>.
cstamas commented on a change in pull request #66:
URL: https://github.com/apache/maven-plugin-tools/pull/66#discussion_r793387172
##########
File path: maven-plugin-plugin/pom.xml
##########
@@ -296,7 +276,7 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-plugin-plugin</artifactId>
- <version>3.6.0</version><!-- cannot use ${mavenPluginToolsVersion} property because release plugin would try to update -->
Review comment:
My take on this https://github.com/apache/maven-release/pull/100
This should fix the m-p-p case but not the MRELEASE-799, that actually to me proves that m-release-p is trying to be "too smart" while it in fact does way too much (and due smartness makes users to introduce "workarounds").
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-plugin-tools] slawekjaranowski commented on a change in pull request #66: [MPLUGIN-388] Make reporting dependency optional
Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on a change in pull request #66:
URL: https://github.com/apache/maven-plugin-tools/pull/66#discussion_r792699198
##########
File path: maven-plugin-plugin/pom.xml
##########
@@ -270,8 +249,7 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-plugin-plugin</artifactId>
- <version>3.6.0</version>
- <!-- will use previous maven-plugin-plugin release to build current maven-plugin-plugin as configured in parent -->
+ <version>3.6.4</version>
Review comment:
please also update version for reporting -> m-p-p
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-plugin-tools] cstamas edited a comment on pull request #66: [MPLUGIN-388] Make reporting dependency optional
Posted by GitBox <gi...@apache.org>.
cstamas edited a comment on pull request #66:
URL: https://github.com/apache/maven-plugin-tools/pull/66#issuecomment-1022934808
@slawekjaranowski fixed them (moved property where used, renamed them to be camelCase).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-plugin-tools] slawekjaranowski commented on pull request #66: [MPLUGIN-388] Make reporting dependency optional
Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on pull request #66:
URL: https://github.com/apache/maven-plugin-tools/pull/66#issuecomment-1022433836
I see some inconsistency - cosmetics
- `mavenInvokerPluginVersion` - defined in root pom used in `maven-plugin-plugin/pom.xml`
- `mavenPluginPlugin.version` - defined and used `plugin-plugin/pom.xml`
- different format of properties for versions once with dot once without dot
maybe `pluginMangment` in project root pom?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-plugin-tools] slawekjaranowski commented on a change in pull request #66: [MPLUGIN-388] Make reporting dependency optional
Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on a change in pull request #66:
URL: https://github.com/apache/maven-plugin-tools/pull/66#discussion_r793363564
##########
File path: maven-plugin-plugin/pom.xml
##########
@@ -296,7 +276,7 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-plugin-plugin</artifactId>
- <version>3.6.0</version><!-- cannot use ${mavenPluginToolsVersion} property because release plugin would try to update -->
Review comment:
https://issues.apache.org/jira/browse/MRELEASE-799
maybe it is a bug only for artifact dependency not for plugins versions ...
according to issue should be reproducible with
```
mvn release:prepare -DdryRun=true ...
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-plugin-tools] cstamas commented on a change in pull request #66: [MPLUGIN-388] Make reporting dependency optional
Posted by GitBox <gi...@apache.org>.
cstamas commented on a change in pull request #66:
URL: https://github.com/apache/maven-plugin-tools/pull/66#discussion_r793387172
##########
File path: maven-plugin-plugin/pom.xml
##########
@@ -296,7 +276,7 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-plugin-plugin</artifactId>
- <version>3.6.0</version><!-- cannot use ${mavenPluginToolsVersion} property because release plugin would try to update -->
Review comment:
My take on this https://github.com/apache/maven-release/pull/100
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-plugin-tools] cstamas edited a comment on pull request #66: [MPLUGIN-388] Make reporting dependency optional
Posted by GitBox <gi...@apache.org>.
cstamas edited a comment on pull request #66:
URL: https://github.com/apache/maven-plugin-tools/pull/66#issuecomment-1022934808
@slawekjaranowski fixed them (moved property where used, renamed them to be camelCase).
Using depMgt in parent for one single (atypical, only plugin) module is overkill IMO.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-plugin-tools] cstamas commented on pull request #66: [MPLUGIN-388] Make reporting dependency optional
Posted by GitBox <gi...@apache.org>.
cstamas commented on pull request #66:
URL: https://github.com/apache/maven-plugin-tools/pull/66#issuecomment-1022934808
@slawekjaranowski fixed then (moved property where used, renamed them to be camelCase).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-plugin-tools] cstamas commented on a change in pull request #66: [MPLUGIN-388] Make reporting dependency optional
Posted by GitBox <gi...@apache.org>.
cstamas commented on a change in pull request #66:
URL: https://github.com/apache/maven-plugin-tools/pull/66#discussion_r793342175
##########
File path: maven-plugin-plugin/pom.xml
##########
@@ -296,7 +276,7 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-plugin-plugin</artifactId>
- <version>3.6.0</version><!-- cannot use ${mavenPluginToolsVersion} property because release plugin would try to update -->
Review comment:
Um, no idea, I tend to avoid m-release-p, never used it (aside of Maven projects). But, if this (otherwise perfectly valid) construct "does not work" with m-release-p, isn't the release plugin that needs to be fixed? Or we want to sprinkle "workarounds" all around as "release plugin would try to update"?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-plugin-tools] cstamas edited a comment on pull request #66: Reshuffle plugin dependencies
Posted by GitBox <gi...@apache.org>.
cstamas edited a comment on pull request #66:
URL: https://github.com/apache/maven-plugin-tools/pull/66#issuecomment-1022232173
> ATTENTION: Reporting plugin cannot have dependencies in the POM. I tripped over it recently.
? No, this is build/plugins/m-p-p plugin is that needs dep added IF you plan to use PluginReport mojo "standalone" (invoke it directly)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-plugin-tools] michael-o commented on pull request #66: Reshuffle plugin dependencies
Posted by GitBox <gi...@apache.org>.
michael-o commented on pull request #66:
URL: https://github.com/apache/maven-plugin-tools/pull/66#issuecomment-1022230827
ATTENTION: Reporting plugin cannot have dependencies in the POM. I tripped over it recently.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-plugin-tools] slawekjaranowski commented on a change in pull request #66: [MPLUGIN-388] Make reporting dependency optional
Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on a change in pull request #66:
URL: https://github.com/apache/maven-plugin-tools/pull/66#discussion_r792819254
##########
File path: maven-plugin-plugin/pom.xml
##########
@@ -270,8 +249,7 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-plugin-plugin</artifactId>
- <version>3.6.0</version>
- <!-- will use previous maven-plugin-plugin release to build current maven-plugin-plugin as configured in parent -->
+ <version>3.6.4</version>
Review comment:
line 277
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-plugin-tools] cstamas commented on a change in pull request #66: [MPLUGIN-388] Make reporting dependency optional
Posted by GitBox <gi...@apache.org>.
cstamas commented on a change in pull request #66:
URL: https://github.com/apache/maven-plugin-tools/pull/66#discussion_r792812013
##########
File path: maven-plugin-plugin/pom.xml
##########
@@ -270,8 +249,7 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-plugin-plugin</artifactId>
- <version>3.6.0</version>
- <!-- will use previous maven-plugin-plugin release to build current maven-plugin-plugin as configured in parent -->
+ <version>3.6.4</version>
Review comment:
and where do I do that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-plugin-tools] cstamas commented on a change in pull request #66: [MPLUGIN-388] Make reporting dependency optional
Posted by GitBox <gi...@apache.org>.
cstamas commented on a change in pull request #66:
URL: https://github.com/apache/maven-plugin-tools/pull/66#discussion_r792854238
##########
File path: maven-plugin-plugin/pom.xml
##########
@@ -270,8 +249,7 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-plugin-plugin</artifactId>
- <version>3.6.0</version>
- <!-- will use previous maven-plugin-plugin release to build current maven-plugin-plugin as configured in parent -->
+ <version>3.6.4</version>
Review comment:
tx, fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-plugin-tools] cstamas commented on a change in pull request #66: [MPLUGIN-388] Make reporting dependency optional
Posted by GitBox <gi...@apache.org>.
cstamas commented on a change in pull request #66:
URL: https://github.com/apache/maven-plugin-tools/pull/66#discussion_r793348555
##########
File path: maven-plugin-plugin/pom.xml
##########
@@ -296,7 +276,7 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-plugin-plugin</artifactId>
- <version>3.6.0</version><!-- cannot use ${mavenPluginToolsVersion} property because release plugin would try to update -->
Review comment:
This is the origin of the comment: https://github.com/apache/maven-plugin-tools/commit/3b54fdbc289fbc33db2366c37579e13a0e087a08 the commit message to me looks like an issue description :smile: (and a very old one)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org