You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2020/05/16 08:38:12 UTC

[GitHub] [incubator-iotdb] neuyilan commented on pull request #1208: [IOTDB-678] LOCAL_IP and SEED_NODES should be consistent in the conf file

neuyilan commented on pull request #1208:
URL: https://github.com/apache/incubator-iotdb/pull/1208#issuecomment-629610210


   > Great, but how about adding "localhost"? Although we can it "IP", but it accepts domain name too.
   > 
   > And one other thing, what if the user mix domain names with IPs? For example, by modifying `HOST`, the user maps "host1,host2,host3" to "192.168.1.1, 192.168.1.2, 192.168.1.3", however, he uses "host1" in the local IP but "192.168.168.1.1" in the seed nodes.
   
   Good idea, I have solved this in this latest commit,  where users can specify the configuration using IP and domain names, please review again, thanks.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org