You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by "desaikomal (via GitHub)" <gi...@apache.org> on 2024/03/06 01:09:58 UTC
[PR] Mark HelixCustomeCodeRunner Deprecated [helix]
desaikomal opened a new pull request, #2774:
URL: https://github.com/apache/helix/pull/2774
### Issues
- [ ] My PR addresses the following Helix issues and references them in the PR description:
### Description
- [ ] Here are some details about my PR, including screenshots of any UI changes:
We have 'GenericLeaderStandbyModel' which has some ST processing not implemented and so if a participant node uses 'CustomRunner' they may see some error related to ST processing.
We are deprecating the GenericLeaderStandbyModel as well.
### Tests
- [ ] The following tests are written for this issue:
(List the names of added unit/integration tests)
- The following is the result of the "mvn test" command on the appropriate module:
(If CI test fails due to known issue, please specify the issue and test PR locally. Then copy & paste the result of "mvn test" to here.)
```
Start zookeeper at localhost:2183 in thread main
START TestDisableCustomCodeRunner_test at Tue Mar 05 17:05:05 PST 2024
END TestDisableCustomCodeRunner_test at Tue Mar 05 17:05:18 PST 2024
AfterClass: TestDisableCustomCodeRunner called.
Shut down zookeeper at port 2183 in thread main
===============================================
Default Suite
Total tests run: 1, Failures: 0, Skips: 0
===============================================
```
and
```
Start zookeeper at localhost:2183 in thread main
START CLUSTER_TestHelixCustomCodeRunner at Tue Mar 05 17:06:43 PST 2024
true: ClusterStateVerifier$BestPossAndExtViewZkVerifier(CLUSTER_TestHelixCustomCodeRunner@localhost:2183): wait 1016ms to verify
END CLUSTER_TestHelixCustomCodeRunner at Tue Mar 05 17:07:01 PST 2024
AfterClass: TestHelixCustomCodeRunner called.
Shut down zookeeper at port 2183 in thread main
===============================================
Default Suite
Total tests run: 1, Failures: 0, Skips: 0
===============================================
Process finished with exit code 0
```
### Changes that Break Backward Compatibility (Optional)
- My PR contains changes that break backward compatibility or previous assumptions for certain methods or API. They include:
(Consider including all behavior changes for public methods or API. Also include these changes in merge description so that other developers are aware of these changes. This allows them to make relevant code changes in feature branches accounting for the new method/API behavior.)
### Documentation (Optional)
- In case of new functionality, my PR adds documentation in the following wiki page:
(Link the GitHub wiki you added)
### Commits
- My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Code Quality
- My diff has been formatted using helix-style.xml
(helix-style-intellij.xml if IntelliJ IDE is used)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
Re: [PR] Mark HelixCustomeCodeRunner Deprecated [helix]
Posted by "junkaixue (via GitHub)" <gi...@apache.org>.
junkaixue merged PR #2774:
URL: https://github.com/apache/helix/pull/2774
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
Re: [PR] Mark HelixCustomeCodeRunner Deprecated [helix]
Posted by "desaikomal (via GitHub)" <gi...@apache.org>.
desaikomal commented on PR #2774:
URL: https://github.com/apache/helix/pull/2774#issuecomment-1988983057
This change has been reviewed and approve by @junkaixue and @himanshukandwal.
Final commit message: Deprecate HelixCustomCodeRunner as it is using deprecated GenericLeaderStandby.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
Re: [PR] Mark HelixCustomeCodeRunner Deprecated [helix]
Posted by "himanshukandwal (via GitHub)" <gi...@apache.org>.
himanshukandwal commented on PR #2774:
URL: https://github.com/apache/helix/pull/2774#issuecomment-1988958847
LGTM, thanks @desaikomal
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org