You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jiang Yan Xu <ya...@jxu.me> on 2017/01/20 23:21:11 UTC

Review Request 55794: Added a security note to `os::system` documentation.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55794/
-----------------------------------------------------------

Review request for mesos, Alex Clemmer, James Peach, and Joseph Wu.


Repository: mesos


Description
-------

Added a security note to `os::system` documentation.


Diffs
-----

  3rdparty/stout/include/stout/os/posix/shell.hpp 70a9184e85ba322f1cd4ce5d12b963cd4b3ad500 
  3rdparty/stout/include/stout/os/windows/shell.hpp 17e3d564564abebf1d558b7a7a277aef3c87e5ae 

Diff: https://reviews.apache.org/r/55794/diff/


Testing
-------

Documentation only change.


Thanks,

Jiang Yan Xu


Re: Review Request 55794: Added a security note to `os::system` documentation.

Posted by James Peach <jp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55794/#review162518
-----------------------------------------------------------


Ship it!




Ship It!

- James Peach


On Jan. 20, 2017, 11:21 p.m., Jiang Yan Xu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55794/
> -----------------------------------------------------------
> 
> (Updated Jan. 20, 2017, 11:21 p.m.)
> 
> 
> Review request for mesos, Alex Clemmer, James Peach, and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added a security note to `os::system` documentation.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/include/stout/os/posix/shell.hpp 70a9184e85ba322f1cd4ce5d12b963cd4b3ad500 
>   3rdparty/stout/include/stout/os/windows/shell.hpp 17e3d564564abebf1d558b7a7a277aef3c87e5ae 
> 
> Diff: https://reviews.apache.org/r/55794/diff/
> 
> 
> Testing
> -------
> 
> Documentation only change.
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>


Re: Review Request 55794: Added a security note to `os::system` documentation.

Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55794/#review162520
-----------------------------------------------------------


Ship it!




Ship It!

- Joseph Wu


On Jan. 20, 2017, 3:21 p.m., Jiang Yan Xu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55794/
> -----------------------------------------------------------
> 
> (Updated Jan. 20, 2017, 3:21 p.m.)
> 
> 
> Review request for mesos, Alex Clemmer, James Peach, and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added a security note to `os::system` documentation.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/include/stout/os/posix/shell.hpp 70a9184e85ba322f1cd4ce5d12b963cd4b3ad500 
>   3rdparty/stout/include/stout/os/windows/shell.hpp 17e3d564564abebf1d558b7a7a277aef3c87e5ae 
> 
> Diff: https://reviews.apache.org/r/55794/diff/
> 
> 
> Testing
> -------
> 
> Documentation only change.
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>