You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by se...@apache.org on 2010/10/12 03:39:20 UTC
svn commit: r1021576 - in
/commons/proper/pool/trunk/src/test/org/apache/commons/pool:
MethodCall.java TestBaseKeyedObjectPool.java
TestBaseKeyedPoolableObjectFactory.java TestBaseObjectPool.java
TestBasePoolableObjectFactory.java TestKeyedObjectPool.java
Author: sebb
Date: Tue Oct 12 01:39:20 2010
New Revision: 1021576
URL: http://svn.apache.org/viewvc?rev=1021576&view=rev
Log:
Missing @Override
Modified:
commons/proper/pool/trunk/src/test/org/apache/commons/pool/MethodCall.java
commons/proper/pool/trunk/src/test/org/apache/commons/pool/TestBaseKeyedObjectPool.java
commons/proper/pool/trunk/src/test/org/apache/commons/pool/TestBaseKeyedPoolableObjectFactory.java
commons/proper/pool/trunk/src/test/org/apache/commons/pool/TestBaseObjectPool.java
commons/proper/pool/trunk/src/test/org/apache/commons/pool/TestBasePoolableObjectFactory.java
commons/proper/pool/trunk/src/test/org/apache/commons/pool/TestKeyedObjectPool.java
Modified: commons/proper/pool/trunk/src/test/org/apache/commons/pool/MethodCall.java
URL: http://svn.apache.org/viewvc/commons/proper/pool/trunk/src/test/org/apache/commons/pool/MethodCall.java?rev=1021576&r1=1021575&r2=1021576&view=diff
==============================================================================
--- commons/proper/pool/trunk/src/test/org/apache/commons/pool/MethodCall.java (original)
+++ commons/proper/pool/trunk/src/test/org/apache/commons/pool/MethodCall.java Tue Oct 12 01:39:20 2010
@@ -77,6 +77,7 @@ public class MethodCall {
return this;
}
+ @Override
public boolean equals(final Object o) {
if (this == o) return true;
if (o == null || getClass() != o.getClass()) return false;
@@ -90,6 +91,7 @@ public class MethodCall {
return true;
}
+ @Override
public int hashCode() {
int result;
result = (name != null ? name.hashCode() : 0);
@@ -98,6 +100,7 @@ public class MethodCall {
return result;
}
+ @Override
public String toString() {
final StringBuffer sb = new StringBuffer();
sb.append("MethodCall");
Modified: commons/proper/pool/trunk/src/test/org/apache/commons/pool/TestBaseKeyedObjectPool.java
URL: http://svn.apache.org/viewvc/commons/proper/pool/trunk/src/test/org/apache/commons/pool/TestBaseKeyedObjectPool.java?rev=1021576&r1=1021575&r2=1021576&view=diff
==============================================================================
--- commons/proper/pool/trunk/src/test/org/apache/commons/pool/TestBaseKeyedObjectPool.java (original)
+++ commons/proper/pool/trunk/src/test/org/apache/commons/pool/TestBaseKeyedObjectPool.java Tue Oct 12 01:39:20 2010
@@ -29,6 +29,7 @@ public class TestBaseKeyedObjectPool ext
super(testName);
}
+ @Override
protected KeyedObjectPool<Object,Object> makeEmptyPool(KeyedPoolableObjectFactory<Object,Object> factory) {
if (this.getClass() != TestBaseKeyedObjectPool.class) {
fail("Subclasses of TestBaseKeyedObjectPool must reimplement this method.");
@@ -69,10 +70,12 @@ public class TestBaseKeyedObjectPool ext
throw new UnsupportedOperationException("BaseKeyedObjectPool isn't a complete implementation.");
}
+ @Override
public void setUp() throws Exception {
super.setUp();
}
+ @Override
public void tearDown() throws Exception {
_pool = null;
super.tearDown();
@@ -83,11 +86,14 @@ public class TestBaseKeyedObjectPool ext
return; // skip redundant tests
}
KeyedObjectPool<Object,Object> pool = new BaseKeyedObjectPool<Object,Object>() {
+ @Override
public Object borrowObject(Object key) {
return null;
}
+ @Override
public void returnObject(Object key, Object obj) {
}
+ @Override
public void invalidateObject(Object key, Object obj) {
}
};
Modified: commons/proper/pool/trunk/src/test/org/apache/commons/pool/TestBaseKeyedPoolableObjectFactory.java
URL: http://svn.apache.org/viewvc/commons/proper/pool/trunk/src/test/org/apache/commons/pool/TestBaseKeyedPoolableObjectFactory.java?rev=1021576&r1=1021575&r2=1021576&view=diff
==============================================================================
--- commons/proper/pool/trunk/src/test/org/apache/commons/pool/TestBaseKeyedPoolableObjectFactory.java (original)
+++ commons/proper/pool/trunk/src/test/org/apache/commons/pool/TestBaseKeyedPoolableObjectFactory.java Tue Oct 12 01:39:20 2010
@@ -29,6 +29,7 @@ public class TestBaseKeyedPoolableObject
public void testDefaultMethods() throws Exception {
KeyedPoolableObjectFactory<Object,Object> factory = new BaseKeyedPoolableObjectFactory<Object,Object>() {
+ @Override
public Object makeObject(Object key) throws Exception {
return null;
}
Modified: commons/proper/pool/trunk/src/test/org/apache/commons/pool/TestBaseObjectPool.java
URL: http://svn.apache.org/viewvc/commons/proper/pool/trunk/src/test/org/apache/commons/pool/TestBaseObjectPool.java?rev=1021576&r1=1021575&r2=1021576&view=diff
==============================================================================
--- commons/proper/pool/trunk/src/test/org/apache/commons/pool/TestBaseObjectPool.java (original)
+++ commons/proper/pool/trunk/src/test/org/apache/commons/pool/TestBaseObjectPool.java Tue Oct 12 01:39:20 2010
@@ -36,6 +36,7 @@ public class TestBaseObjectPool extends
throw new UnsupportedOperationException("BaseObjectPool isn't a complete implementation.");
}
+ @Override
protected ObjectPool<Object> makeEmptyPool(final PoolableObjectFactory<Object> factory) {
if (this.getClass() != TestBaseObjectPool.class) {
fail("Subclasses of TestBaseObjectPool must reimplement this method.");
@@ -70,11 +71,14 @@ public class TestBaseObjectPool extends
return; // skip redundant tests
}
ObjectPool<Object> pool = new BaseObjectPool<Object>() {
+ @Override
public Object borrowObject() {
return null;
}
+ @Override
public void returnObject(Object obj) {
}
+ @Override
public void invalidateObject(Object obj) {
}
};
@@ -106,11 +110,14 @@ public class TestBaseObjectPool extends
public void testClose() throws Exception {
ObjectPool<Object> pool = new BaseObjectPool<Object>() {
+ @Override
public Object borrowObject() {
return null;
}
+ @Override
public void returnObject(Object obj) {
}
+ @Override
public void invalidateObject(Object obj) {
}
};
Modified: commons/proper/pool/trunk/src/test/org/apache/commons/pool/TestBasePoolableObjectFactory.java
URL: http://svn.apache.org/viewvc/commons/proper/pool/trunk/src/test/org/apache/commons/pool/TestBasePoolableObjectFactory.java?rev=1021576&r1=1021575&r2=1021576&view=diff
==============================================================================
--- commons/proper/pool/trunk/src/test/org/apache/commons/pool/TestBasePoolableObjectFactory.java (original)
+++ commons/proper/pool/trunk/src/test/org/apache/commons/pool/TestBasePoolableObjectFactory.java Tue Oct 12 01:39:20 2010
@@ -29,6 +29,7 @@ public class TestBasePoolableObjectFacto
public void testDefaultMethods() throws Exception {
PoolableObjectFactory<Object> factory = new BasePoolableObjectFactory<Object>() {
+ @Override
public Object makeObject() throws Exception {
return null;
}
Modified: commons/proper/pool/trunk/src/test/org/apache/commons/pool/TestKeyedObjectPool.java
URL: http://svn.apache.org/viewvc/commons/proper/pool/trunk/src/test/org/apache/commons/pool/TestKeyedObjectPool.java?rev=1021576&r1=1021575&r2=1021576&view=diff
==============================================================================
--- commons/proper/pool/trunk/src/test/org/apache/commons/pool/TestKeyedObjectPool.java (original)
+++ commons/proper/pool/trunk/src/test/org/apache/commons/pool/TestKeyedObjectPool.java Tue Oct 12 01:39:20 2010
@@ -50,6 +50,7 @@ public abstract class TestKeyedObjectPoo
final KeyedObjectPool<Object,Object> pool;
try {
pool = makeEmptyPool(new BaseKeyedPoolableObjectFactory<Object,Object>() {
+ @Override
public Object makeObject(final Object key) throws Exception {
return new Object();
}