You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@sqoop.apache.org by Abraham Fine <ab...@abrahamfine.com> on 2016/02/25 01:50:08 UTC

Review Request 43972: SQOOP-2845

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43972/
-----------------------------------------------------------

Review request for Sqoop.


Bugs: SQOOP-2845
    https://issues.apache.org/jira/browse/SQOOP-2845


Repository: sqoop-sqoop2


Description
-------

Sqoop2: Derive keystore password from a script passed to configuration


Diffs
-----

  core/src/main/java/org/apache/sqoop/security/SecurityConstants.java 6f32e04be6fc47051e7c0cc90a881cb872cb3934 
  dist/src/main/conf/sqoop.properties 620146d5c8a2f736d5d139e6452b0165cbdfaa17 
  server/src/main/java/org/apache/sqoop/server/SqoopJettyServer.java 2c4cb7a13aacd1e4e3222d54fb3b1ef518aa2ebb 
  server/src/main/java/org/apache/sqoop/server/common/ServerError.java 1b021cf27defee1493ad620466a89b9fae1b5bb5 
  test/pom.xml 1e88b34a684709e7a0ad8a71480e7bad37a94398 
  test/src/main/java/org/apache/sqoop/test/infrastructure/SqoopTestCase.java e3fbe315e2b23735e2e31321b038dd88c5f99021 
  test/src/main/java/org/apache/sqoop/test/kdc/MiniKdcRunner.java 83f960b87987d1c1ed8f0161616e631f63f14543 
  test/src/main/java/org/apache/sqoop/test/utils/SecurityUtils.java PRE-CREATION 
  test/src/main/java/org/apache/sqoop/test/utils/SqoopUtils.java 6614b19932c304aa40500fcaedd974b1b136caec 
  test/src/test/java/org/apache/sqoop/integration/connectorloading/BlacklistedConnectorTest.java 7f0575b49c58fcec1c69069f25929411a6c7ba12 
  test/src/test/java/org/apache/sqoop/integration/connectorloading/ClasspathTest.java 87f0eb1966de4d7ea9b1c37b881cad0ae7a88fa4 
  test/src/test/java/org/apache/sqoop/integration/connectorloading/ConnectorClasspathIsolationTest.java a82a4daea607bee4e78bf2a649b7c9d5228448be 
  test/src/test/java/org/apache/sqoop/integration/serverproperties/SslTest.java PRE-CREATION 
  test/src/test/resources/connector-loading-tests-suite.xml c03fb4f008ec75a65efbd6ad6c4eb33d37099124 

Diff: https://reviews.apache.org/r/43972/diff/


Testing
-------

yes


Thanks,

Abraham Fine

Re: Review Request 43972: SQOOP-2845

Posted by Jarek Cecho <ja...@apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43972/#review121309
-----------------------------------------------------------



Few comments, otherwise looks good to me.


core/src/main/java/org/apache/sqoop/security/SecurityConstants.java (lines 196 - 197)
<https://reviews.apache.org/r/43972/#comment182991>

    Nit: The comment seems outdated.



core/src/main/java/org/apache/sqoop/security/SecurityConstants.java (lines 211 - 213)
<https://reviews.apache.org/r/43972/#comment182992>

    Nit: Outdated comment.



server/src/main/java/org/apache/sqoop/server/SqoopJettyServer.java (lines 100 - 103)
<https://reviews.apache.org/r/43972/#comment182993>

    Should we also solve the case when both kyStorePassword and passwordGenerator are present and perhaps thrown an exception or log a message that this is invalid configuration?


Jarcec

- Jarek Cecho


On Feb. 27, 2016, 12:20 a.m., Abraham Fine wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43972/
> -----------------------------------------------------------
> 
> (Updated Feb. 27, 2016, 12:20 a.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Bugs: SQOOP-2845
>     https://issues.apache.org/jira/browse/SQOOP-2845
> 
> 
> Repository: sqoop-sqoop2
> 
> 
> Description
> -------
> 
> Sqoop2: Derive keystore password from a script passed to configuration
> 
> 
> Diffs
> -----
> 
>   core/src/main/java/org/apache/sqoop/security/SecurityConstants.java 91a1b8bb0b4a266381faccd11617bba236c6b446 
>   server/src/main/java/org/apache/sqoop/server/SqoopJettyServer.java 60368afc0af8b899696476607a5c0bc6d6084794 
>   server/src/main/java/org/apache/sqoop/server/common/ServerError.java a644e9f10ba792a9c36d5b90db1b5d7f29569e43 
>   test/src/main/java/org/apache/sqoop/test/infrastructure/SqoopTestCase.java e3fbe315e2b23735e2e31321b038dd88c5f99021 
>   test/src/test/java/org/apache/sqoop/integration/serverproperties/SslTest.java 17503f3f24ce8344e96e6f7c60085f015eac38f7 
> 
> Diff: https://reviews.apache.org/r/43972/diff/
> 
> 
> Testing
> -------
> 
> yes
> 
> 
> Thanks,
> 
> Abraham Fine
> 
>