You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2021/02/03 07:30:04 UTC
[GitHub] [incubator-doris] vinson0526 opened a new pull request #5352: remove log4j1 from dependency in fe, use slf4j + slf4j -> log4j2 instead
vinson0526 opened a new pull request #5352:
URL: https://github.com/apache/incubator-doris/pull/5352
Because only few class use log4j version 1 to do logging. So remove it, and use slf4j + log4j-slf4j-impl instead. This keep Doris logging system simple and easy to use.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] EmmyMiao87 commented on a change in pull request #5352: remove log4j1 from dependency in fe, use slf4j + slf4j -> log4j2 instead
Posted by GitBox <gi...@apache.org>.
EmmyMiao87 commented on a change in pull request #5352:
URL: https://github.com/apache/incubator-doris/pull/5352#discussion_r569330200
##########
File path: fe/fe-core/src/test/java/org/apache/doris/analysis/CreateRoutineLoadStmtTest.java
##########
@@ -43,10 +41,12 @@
import mockit.Mock;
import mockit.MockUp;
import mockit.Mocked;
+import org.slf4j.Logger;
Review comment:
please pay attention order of import
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] vinson0526 closed pull request #5352: remove log4j1 from dependency in fe, use slf4j + slf4j -> log4j2 instead
Posted by GitBox <gi...@apache.org>.
vinson0526 closed pull request #5352:
URL: https://github.com/apache/incubator-doris/pull/5352
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org