You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Tim Armstrong (Code Review)" <ge...@cloudera.org> on 2017/01/12 23:28:49 UTC
[Impala-ASF-CR] IMPALA-4757: addendum: avoid double underscore prefix
Tim Armstrong has uploaded a new change for review.
http://gerrit.cloudera.org:8080/5702
Change subject: IMPALA-4757: addendum: avoid double underscore prefix
......................................................................
IMPALA-4757: addendum: avoid double underscore prefix
Names starting with double underscore are implementation-reserved.
E.g. a global macro called __status could in principle be defined
in a C++ system header.
Change-Id: I9b189fe1ec1e70e19b2fd0ed8b183b7569e5fd05
---
M be/src/testutil/gtest-util.h
1 file changed, 6 insertions(+), 6 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/02/5702/1
--
To view, visit http://gerrit.cloudera.org:8080/5702
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9b189fe1ec1e70e19b2fd0ed8b183b7569e5fd05
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-4757: addendum: avoid double underscore in name
Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Jim Apple has posted comments on this change.
Change subject: IMPALA-4757: addendum: avoid double underscore in name
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5702
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9b189fe1ec1e70e19b2fd0ed8b183b7569e5fd05
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4757: addendum: avoid double underscore in name
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has uploaded a new patch set (#3).
Change subject: IMPALA-4757: addendum: avoid double underscore in name
......................................................................
IMPALA-4757: addendum: avoid double underscore in name
Names containing double underscore are implementation-reserved.
E.g. a global macro called __status could in principle be defined
in a C++ system header.
Change-Id: I9b189fe1ec1e70e19b2fd0ed8b183b7569e5fd05
---
M be/src/testutil/gtest-util.h
1 file changed, 12 insertions(+), 12 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/02/5702/3
--
To view, visit http://gerrit.cloudera.org:8080/5702
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9b189fe1ec1e70e19b2fd0ed8b183b7569e5fd05
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
[Impala-ASF-CR] IMPALA-4757: addendum: avoid double underscore in name
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4757: addendum: avoid double underscore in name
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5702/1//COMMIT_MSG
Commit Message:
PS1, Line 9: starting
> containing:
Done
--
To view, visit http://gerrit.cloudera.org:8080/5702
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9b189fe1ec1e70e19b2fd0ed8b183b7569e5fd05
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-4757: addendum: avoid double underscore prefix
Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Jim Apple has posted comments on this change.
Change subject: IMPALA-4757: addendum: avoid double underscore prefix
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5702/1//COMMIT_MSG
Commit Message:
PS1, Line 9: starting
containing:
http://eel.is/c++draft/lex.name#3.1
--
To view, visit http://gerrit.cloudera.org:8080/5702
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9b189fe1ec1e70e19b2fd0ed8b183b7569e5fd05
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-4757: addendum: avoid double underscore in name
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-4757: addendum: avoid double underscore in name
......................................................................
Patch Set 3: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/5702
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9b189fe1ec1e70e19b2fd0ed8b183b7569e5fd05
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4757: addendum: avoid double underscore in name
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged.
Change subject: IMPALA-4757: addendum: avoid double underscore in name
......................................................................
IMPALA-4757: addendum: avoid double underscore in name
Names containing double underscore are implementation-reserved.
E.g. a global macro called __status could in principle be defined
in a C++ system header.
Change-Id: I9b189fe1ec1e70e19b2fd0ed8b183b7569e5fd05
Reviewed-on: http://gerrit.cloudera.org:8080/5702
Reviewed-by: Jim Apple <jb...@apache.org>
Tested-by: Impala Public Jenkins
---
M be/src/testutil/gtest-util.h
1 file changed, 12 insertions(+), 12 deletions(-)
Approvals:
Impala Public Jenkins: Verified
Jim Apple: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/5702
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9b189fe1ec1e70e19b2fd0ed8b183b7569e5fd05
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-4757: addendum: avoid double underscore prefix
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has uploaded a new patch set (#2).
Change subject: IMPALA-4757: addendum: avoid double underscore prefix
......................................................................
IMPALA-4757: addendum: avoid double underscore prefix
Names starting with double underscore are implementation-reserved.
E.g. a global macro called __status could in principle be defined
in a C++ system header.
Change-Id: I9b189fe1ec1e70e19b2fd0ed8b183b7569e5fd05
---
M be/src/testutil/gtest-util.h
1 file changed, 12 insertions(+), 12 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/02/5702/2
--
To view, visit http://gerrit.cloudera.org:8080/5702
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9b189fe1ec1e70e19b2fd0ed8b183b7569e5fd05
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
[Impala-ASF-CR] IMPALA-4757: addendum: avoid double underscore in name
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-4757: addendum: avoid double underscore in name
......................................................................
Patch Set 3:
Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/188/
--
To view, visit http://gerrit.cloudera.org:8080/5702
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9b189fe1ec1e70e19b2fd0ed8b183b7569e5fd05
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: No