[GitHub] [guacamole-client] mike-jumper commented on pull request #573: GUACAMOLE-680: Implement a guaranteed logout handler hook

[GitBox <gi...@apache.org>]

mike-jumper commented on pull request #573:
URL: https://github.com/apache/guacamole-client/pull/573#issuecomment-826389806


   > Am I missing some other promise API that is already included in Guacamole-client?
   
   While there _is_ a promise API included within the Guacamole webapp via AngularJS (`$q`), there isn't one included with guacamole-common-js, and the core guacamole-common-js shouldn't rely on the promise API if this would affect compatibility with older browsers.
   
   Shouldn't the change leveraging the promise be at the webapp level rather than in guacamole-common-js? The former is a full-fledged webapp that can rely on bundling any libraries it requires, while the latter is a reusable library that should not be too tightly coupled with the needs of the webapp.
   
   If modifying guacamole-common-js to support promises if the implementation wishes to use promises, this could make sense, but it shouldn't require them.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org