You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geronimo.apache.org by "John Sisson (JIRA)" <de...@geronimo.apache.org> on 2005/02/04 06:53:25 UTC

[jira] Created: (GERONIMO-568) Switch system-datasource plan to the derby xa connector

Switch system-datasource plan to the derby xa connector
-------------------------------------------------------

         Key: GERONIMO-568
         URL: http://issues.apache.org/jira/browse/GERONIMO-568
     Project: Apache Geronimo
        Type: Improvement
    Reporter: John Sisson
    Priority: Minor


In a dev mail discussion titled "Re: derby-connector RAR not in Geronimo's repository directory", David Jencks suggested it would be a good idea to switch the system-datasource plan to the xa connector as well as moving the timer gbeans to the system datasource plan.  

I am currently working on a patch.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


Re: [jira] Created: (GERONIMO-568) Switch system-datasource plan to the derby xa connector

Posted by si...@insession.com.
sissonj@insession.com wrote on 10/02/2005 01:34:22 PM:

> I am working on a patch for switching system-datasource plan to the 
derby 
> xa connector as well as moving the timer gbeans to the system datasource 

> plan. http://issues.apache.org/jira/browse/GERONIMO-568
> 
> I am having a problem where the 
JDBCStoreThreadPooledNonTransactionalTimer 
> GBean is being invoked before the DerbySystemGBean.
> 
> The JDBCStoreThreadPooledNonTransactionalTimer constructor creates a new 

> instance of JDBCWorkerPersistence, which then calls the execSQL method 
in 
> its superclass that opens a database connection, therefore initialising 
> the embedded derby database.
> 
> One of the problems with this is that the SystemDatabase and derby.log 
are 
> not created under geronimo\var\derby (since the derby.system.home 
property 
> is set by the DerbySystemGBean, which hasn't been started yet.
> 
> Both the timer GBeans have a reference to 
> geronimo.server:J2EEApplication=null,J2EEServer=geronimo,
> JCAResource=org/apache/geronimo/SystemDatabase,
> j2eeType=JCAManagedConnectionFactory,name=SystemDatasource,*
> 
> The SystemDatasource GBean reference is shown as started in the log 
before 
> Derby has been initialised.
> 
> Some options to discuss:
> 
> * Have the Timer GBeans have a reference to the DerbySystem GBean, so 
they 
> aren't started until the DerbySystem GBean has started.  Do you really 
> want a DerbySystem parameter on the constructor of the Timer GBeans? 
Even 
> if we do this, it won't stop future GBeans referencing the 
> SystemDatasource when Derby hasn't been initialised.

FYI.. After an IRC discussion with David Jencks and Dain I ended up taking 
this option.

John

> 
> * Have the SystemDatasource Gbean have a reference to the DerbySystem 
> GBean, so the SystemDatasource is not started until the DerbySystem 
GBean 
> has started.  Not sure how this can be done and how practical it is.
> 
> * Have a new system-derby-plan.xml file with 
> configId="org/apache/geronimo/DerbySystem" and 
> parentId="org/apache/geronimo/Server" that contains the DerbySystem and 
> DerbyNetwork gbeans .  Change the system-database-plan.xml file to have 
> parentId="org/apache/geronimo/DerbySystem".
> 
> Thanks,
> 
> John
> 


Re: [jira] Created: (GERONIMO-568) Switch system-datasource plan to the derby xa connector

Posted by si...@insession.com.
I am working on a patch for switching system-datasource plan to the derby 
xa connector as well as moving the timer gbeans to the system datasource 
plan. http://issues.apache.org/jira/browse/GERONIMO-568

I am having a problem where the JDBCStoreThreadPooledNonTransactionalTimer 
GBean is being invoked before the DerbySystemGBean.

The JDBCStoreThreadPooledNonTransactionalTimer constructor creates a new 
instance of JDBCWorkerPersistence, which then calls the execSQL method in 
its superclass that opens a database connection, therefore initialising 
the embedded derby database.

One of the problems with this is that the SystemDatabase and derby.log are 
not created under geronimo\var\derby (since the derby.system.home property 
is set by the DerbySystemGBean, which hasn't been started yet.

Both the timer GBeans have a reference to 
geronimo.server:J2EEApplication=null,J2EEServer=geronimo,JCAResource=org/apache/geronimo/SystemDatabase,j2eeType=JCAManagedConnectionFactory,name=SystemDatasource,*

The SystemDatasource GBean reference is shown as started in the log before 
Derby has been initialised.

Some options to discuss:

* Have the Timer GBeans have a reference to the DerbySystem GBean, so they 
aren't started until the DerbySystem GBean has started.  Do you really 
want a DerbySystem parameter on the constructor of the Timer GBeans?  Even 
if we do this, it won't stop future GBeans referencing the 
SystemDatasource when Derby hasn't been initialised.

* Have the SystemDatasource Gbean have a reference to the DerbySystem 
GBean, so the SystemDatasource is not started until the DerbySystem GBean 
has started.  Not sure how this can be done and how practical it is.

* Have a new system-derby-plan.xml file with 
configId="org/apache/geronimo/DerbySystem" and 
parentId="org/apache/geronimo/Server" that contains the DerbySystem and 
DerbyNetwork gbeans .  Change the system-database-plan.xml file to have 
parentId="org/apache/geronimo/DerbySystem".

Thanks,

John


[jira] Assigned: (GERONIMO-568) Switch system-datasource plan to the derby xa connector

Posted by "David Jencks (JIRA)" <de...@geronimo.apache.org>.
     [ http://issues.apache.org/jira/browse/GERONIMO-568?page=history ]

David Jencks reassigned GERONIMO-568:
-------------------------------------

    Assign To: David Jencks

> Switch system-datasource plan to the derby xa connector
> -------------------------------------------------------
>
>          Key: GERONIMO-568
>          URL: http://issues.apache.org/jira/browse/GERONIMO-568
>      Project: Geronimo
>         Type: Improvement
>     Reporter: John Sisson
>     Assignee: David Jencks
>     Priority: Minor
>  Attachments: SystemDatasource_patch.txt
>
> In a dev mail discussion titled "Re: derby-connector RAR not in Geronimo's repository directory", David Jencks suggested it would be a good idea to switch the system-datasource plan to the xa connector as well as moving the timer gbeans to the system datasource plan.  
> I am currently working on a patch.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


[jira] Closed: (GERONIMO-568) Switch system-datasource plan to the derby xa connector

Posted by "David Jencks (JIRA)" <de...@geronimo.apache.org>.
     [ http://issues.apache.org/jira/browse/GERONIMO-568?page=history ]
     
David Jencks closed GERONIMO-568:
---------------------------------

     Resolution: Fixed
    Fix Version: 1.0-M4

Applied, many thanks!

> Switch system-datasource plan to the derby xa connector
> -------------------------------------------------------
>
>          Key: GERONIMO-568
>          URL: http://issues.apache.org/jira/browse/GERONIMO-568
>      Project: Geronimo
>         Type: Improvement
>     Reporter: John Sisson
>     Assignee: David Jencks
>     Priority: Minor
>      Fix For: 1.0-M4
>  Attachments: SystemDatasource_patch.txt
>
> In a dev mail discussion titled "Re: derby-connector RAR not in Geronimo's repository directory", David Jencks suggested it would be a good idea to switch the system-datasource plan to the xa connector as well as moving the timer gbeans to the system datasource plan.  
> I am currently working on a patch.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


[jira] Updated: (GERONIMO-568) Switch system-datasource plan to the derby xa connector

Posted by "John Sisson (JIRA)" <de...@geronimo.apache.org>.
     [ http://issues.apache.org/jira/browse/GERONIMO-568?page=history ]

John Sisson updated GERONIMO-568:
---------------------------------

    Attachment: SystemDatasource_patch.txt

Patch attached for review.

Notes: The JDBCTransactionalThreadPooledTimer and JDBCNonTransactionalThreadPooledTimer GBeans will not be started until DerbySystem has started, by having a reference to DerbySystem.  

The reference to DerbySystem was introduced because without the reference, when the timer GBeans are started then they will open their datasource causing Derby to be initialised (without derby.system.home being set) causing databases and log files to be created in the wrong location.

> Switch system-datasource plan to the derby xa connector
> -------------------------------------------------------
>
>          Key: GERONIMO-568
>          URL: http://issues.apache.org/jira/browse/GERONIMO-568
>      Project: Geronimo
>         Type: Improvement
>     Reporter: John Sisson
>     Priority: Minor
>  Attachments: SystemDatasource_patch.txt
>
> In a dev mail discussion titled "Re: derby-connector RAR not in Geronimo's repository directory", David Jencks suggested it would be a good idea to switch the system-datasource plan to the xa connector as well as moving the timer gbeans to the system datasource plan.  
> I am currently working on a patch.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira