You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by "Andrew Westberg (JIRA)" <ji...@apache.org> on 2010/09/30 19:17:40 UTC

[jira] Created: (AMQNET-288) Possible issue with shutdown() functions in States

Possible issue with shutdown() functions in States
--------------------------------------------------

                 Key: AMQNET-288
                 URL: https://issues.apache.org/activemq/browse/AMQNET-288
             Project: ActiveMQ .Net
          Issue Type: Bug
          Components: NMS
            Reporter: Andrew Westberg
            Assignee: Jim Gomes


I noticed that in the code for SessionState.cs and TransactionState.cs, when the shutdown() method is called, the value for _shutdown is set to false.  Based on the code, shouldn't this be setting the value to true as is done in ConnectionState.cs?  I don't see from the code, how it's ever possible to set the private variable _shutdown to true.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (AMQNET-288) Possible issue with shutdown() functions in States

Posted by "Timothy Bish (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/activemq/browse/AMQNET-288?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Timothy Bish resolved AMQNET-288.
---------------------------------

       Resolution: Fixed
    Fix Version/s: 1.5.0
         Assignee: Timothy Bish  (was: Jim Gomes)

Reviewed the code and it is incorrect.  Fixed it so an error will get thrown if the state tracker attempt to associate resources with closed out Transactions or Sessions.

> Possible issue with shutdown() functions in States
> --------------------------------------------------
>
>                 Key: AMQNET-288
>                 URL: https://issues.apache.org/activemq/browse/AMQNET-288
>             Project: ActiveMQ .Net
>          Issue Type: Bug
>          Components: NMS
>            Reporter: Andrew Westberg
>            Assignee: Timothy Bish
>             Fix For: 1.5.0
>
>
> I noticed that in the code for SessionState.cs and TransactionState.cs, when the shutdown() method is called, the value for _shutdown is set to false.  Based on the code, shouldn't this be setting the value to true as is done in ConnectionState.cs?  I don't see from the code, how it's ever possible to set the private variable _shutdown to true.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (AMQNET-288) Possible issue with shutdown() functions in States

Posted by "Jim Gomes (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/activemq/browse/AMQNET-288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=62252#action_62252 ] 

Jim Gomes commented on AMQNET-288:
----------------------------------

Hi Andrew,

Thanks for reviewing the code.  However, it would be helpful if you could produce a test case scenario that exposes an actual problem.  Until then, this isn't an actionable item.


> Possible issue with shutdown() functions in States
> --------------------------------------------------
>
>                 Key: AMQNET-288
>                 URL: https://issues.apache.org/activemq/browse/AMQNET-288
>             Project: ActiveMQ .Net
>          Issue Type: Bug
>          Components: NMS
>            Reporter: Andrew Westberg
>            Assignee: Jim Gomes
>
> I noticed that in the code for SessionState.cs and TransactionState.cs, when the shutdown() method is called, the value for _shutdown is set to false.  Based on the code, shouldn't this be setting the value to true as is done in ConnectionState.cs?  I don't see from the code, how it's ever possible to set the private variable _shutdown to true.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.