You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by bu...@apache.org on 2017/06/28 18:06:48 UTC

[Bug 61232] New: Disabling rotation on the FileHandler creates 'catalina..log' instead of 'catalina.log'

https://bz.apache.org/bugzilla/show_bug.cgi?id=61232

            Bug ID: 61232
           Summary: Disabling rotation on the FileHandler creates
                    'catalina..log' instead of 'catalina.log'
           Product: Tomcat 8
           Version: 8.5.x-trunk
          Hardware: PC
                OS: Linux
            Status: NEW
          Severity: trivial
          Priority: P2
         Component: JULI
          Assignee: dev@tomcat.apache.org
          Reporter: csutherl@redhat.com
  Target Milestone: ----

This is a trivial thing, but I thought it a good Beginner issue (unless someone
thinks that this is expected behavior).

When you disable rotatable in the default logging.properties tomcat creates
'catalina..log' rather than the correct 'catalina.log' file. There is no
functional issue, but it seems kinda buggy to do that. You can easily
workaround it by overriding the default suffix with
"1catalina.org.apache.juli.AsyncFileHandler.suffix=log".

To reproduce:

1) Install tomcat
2) Disable log rotation

$ echo "1catalina.org.apache.juli.AsyncFileHandler.rotatable = false" >>
conf/logging.properties

3) Start tomcat

bin/startup.sh

4) Check the logs directory for catalina log with double '.'s:

$ ll logs/catalina.*log
-rw-r-----. 1 coty coty 7796 Jun 28 13:58 logs/catalina..log

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


[Bug 61232] Disabling rotation on the FileHandler creates 'catalina..log' instead of 'catalina.log'

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=61232

Coty Sutherland <cs...@redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |Beginner

--- Comment #1 from Coty Sutherland <cs...@redhat.com> ---
Looking at the o.a.juli.FileHandler class, one option would be to check the
rotatable variable inside of configure() and adjust the suffix accordingly so
that it doesn't add a '.' if rotatable is off (the prefix ends in '.' so unless
it's non-default, which you could also check, it should have the necessary
separator).

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


[Bug 61232] Disabling rotation on the FileHandler creates 'catalina..log' instead of 'catalina.log'

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=61232

--- Comment #2 from Violeta Georgieva <vi...@apache.org> ---
PR https://github.com/apache/tomcat/pull/69

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


[Bug 61232] Disabling rotation on the FileHandler creates 'catalina..log' instead of 'catalina.log'

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=61232

Violeta Georgieva <vi...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #3 from Violeta Georgieva <vi...@apache.org> ---
PR #69 provided by Katya Stoycheva is applied to:

- trunk for 9.0.0.M24 onwards
- 8.5.x for 8.5.18 onwards
- 8.0.x for 8.0.46 onwards
- 7.0.x for 7.0.80 onwards

Regards,
Violeta

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org