[jira] [Commented] (CLOUDSTACK-8896) Allocated percentage of storage can go beyond 100%

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-8896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14939364#comment-14939364 ] 

ASF GitHub Bot commented on CLOUDSTACK-8896:
--------------------------------------------

Github user karuturi commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/873#discussion_r40881830
  
    --- Diff: server/src/com/cloud/storage/StorageManagerImpl.java ---
    @@ -1736,7 +1737,10 @@ public boolean storagePoolHasEnoughSpace(List<Volume> volumes, StoragePool pool)
                         allocatedSizeWithtemplate = _capacityMgr.getAllocatedPoolCapacity(poolVO, tmpl);
                     }
                 }
    -            if (volumeVO.getState() != Volume.State.Ready) {
    +            // A ready state volume is already allocated in a pool. so the asking size is zero for it.
    +            // In case the volume is moving across pools or is not ready yet, the asking size has to be computed
    +            s_logger.debug("pool id for the volume with id: " + volumeVO.getId() + " is: " + volumeVO.getPoolId());
    --- End diff --
    
    @wido numeric ids in logs are easy to understand/debug than uuids. names might me more readable but ids are unique and hence no ambiguity. 
    The current pool-id is already logged and the pool-id of the the volume would help me see if the volume is moving across pools. That was the information I was looking for while debugging this issue and was hard to find given nothing was logged before.


> Allocated percentage of storage can go beyond 100%
> --------------------------------------------------
>
>                 Key: CLOUDSTACK-8896
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8896
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the default.) 
>    Affects Versions: 4.5.2, 4.6.0
>            Reporter: Rajani Karuturi
>            Assignee: Rajani Karuturi
>
> This issue occurs when a volume in Ready state is moved across storage pools.
> Let us say there is a data volume, volume0 in Ready state in a cluster scope primary storage primary0.
> Now, when an operation is attempted to attach this volume to a vm in another cluster, the volume is moved to the new cluster and the asking size is zero at this time.
> you can observe logs like below with asking size 0 in the management server logs.
> 2015-09-22 08:49:02,754 DEBUG [c.c.s.StorageManagerImpl] (Work-Job-Executor-6:ctx-27e0990a job-37/job-38 ctx-985e5ad0) (logid:a0a97129) Checking pool: 1 for volume allocation [Vol[8|vm=null|DATADISK]], maxSize : 3298534883328, totalAllocatedSize : 24096276480, askingSize : 0, allocated disable threshold: 0.85



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)