You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "onderson (via GitHub)" <gi...@apache.org> on 2023/05/18 10:54:47 UTC
[GitHub] [camel-quarkus] onderson opened a new pull request, #4916: fix links in contibutor docs.
onderson opened a new pull request, #4916:
URL: https://github.com/apache/camel-quarkus/pull/4916
<!-- Uncomment and fill this section if your PR is not trivial
[ ] An issue should be filed for the change unless this is a trivial change (fixing a typo or similar). One issue should ideally be fixed by not more than one commit and the other way round, each commit should fix just one issue, without pulling in other changes.
[ ] Each commit in the pull request should have a meaningful and properly spelled subject line and body. Copying the title of the associated issue is typically enough. Please include the issue number in the commit message prefixed by #.
[ ] The pull request description should explain what the pull request does, how, and why. If the info is available in the associated issue or some other external document, a link is enough.
[ ] Phrases like Fix #<issueNumber> or Fixes #<issueNumber> will auto-close the named issue upon merging the pull request. Using them is typically a good idea.
[ ] Please run mvn process-resources -Pformat (and amend the changes if necessary) before sending the pull request.
[ ] Contributor guide is your good friend: https://camel.apache.org/camel-quarkus/latest/contributor-guide.html
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ppalaga closed pull request #4916: fix links in contibutor docs.
Posted by "ppalaga (via GitHub)" <gi...@apache.org>.
ppalaga closed pull request #4916: fix links in contibutor docs.
URL: https://github.com/apache/camel-quarkus/pull/4916
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] onderson commented on pull request #4916: fix links in contibutor docs.
Posted by "onderson (via GitHub)" <gi...@apache.org>.
onderson commented on PR #4916:
URL: https://github.com/apache/camel-quarkus/pull/4916#issuecomment-1557081763
i am not sure if this have an impact on how the site is built. i just followed github links and it was giving error as
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ppalaga commented on pull request #4916: fix links in contibutor docs.
Posted by "ppalaga (via GitHub)" <gi...@apache.org>.
ppalaga commented on PR #4916:
URL: https://github.com/apache/camel-quarkus/pull/4916#issuecomment-1559716485
Indeed, now your PR makes much more sense to us! As it happens, these adoc files are not primarily intended for github browsing. They serve as an input for Apache Camel site build whose resuts can be visible at https://camel.apache.org/camel-quarkus/latest/index.html Hence links work as designed. Thanks for taking care anyway!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] jamesnetherton commented on pull request #4916: fix links in contibutor docs.
Posted by "jamesnetherton (via GitHub)" <gi...@apache.org>.
jamesnetherton commented on PR #4916:
URL: https://github.com/apache/camel-quarkus/pull/4916#issuecomment-1552926758
> I have some doubts, even on the other PR, I'm not sure the website will build in this way.
Yeah I was curious about it. The website is working fine as things are. Wondering why these changes are needed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org