[GitHub] piiswrong commented on a change in pull request #10425: [MXNET-175] Raise user warning on mismatch between module data_names and data iter names

[GitBox <gi...@apache.org>]

piiswrong commented on a change in pull request #10425: [MXNET-175] Raise user warning on mismatch between module data_names and data iter names
URL: https://github.com/apache/incubator-mxnet/pull/10425#discussion_r183512320
 
 

 ##########
 File path: python/mxnet/module/base_module.py
 ##########
 @@ -78,6 +79,17 @@ def _parse_data_desc(data_names, label_names, data_shapes, label_shapes):
     return data_shapes, label_shapes
 
 
+def _check_data_names(eval_data, data_names):
+    """ Check if iterator data names match the data names provided in module"""
+    if isinstance(eval_data, io.NDArrayIter) and \
 
 Review comment:
   This is still special casing NDArrayIter. The same problem would happen for all dataiters if names are incorrect.
   Why do we need renamed_data attribute?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services