[GitHub] [incubator-mxnet] Zha0q1 commented on a change in pull request #19846: [wip] [v1.x] Onnx export support for slicechannel and box_nms

[GitBox <gi...@apache.org>]

Zha0q1 commented on a change in pull request #19846:
URL: https://github.com/apache/incubator-mxnet/pull/19846#discussion_r570677256



##########
File path: tests/python-pytest/onnx/test_operators.py
##########
@@ -923,3 +923,16 @@ def test_onnx_export_convolution(tmp_path, dtype, shape, num_filter, num_group,
                   **kwargs)
     inputs = [x, w] if no_bias else [x, w, b]
     op_export_test('convolution', M, inputs, tmp_path)
+
+
+@pytest.mark.parametrize('dtype', ['float16', 'float32'])
+@pytest.mark.parametrize('num_outputs', [1, 3, 9])
+@pytest.mark.parametrize('axis', [1, 2, -1, -2])
+@pytest.mark.parametrize('squeeze_axis', [True, False])

Review comment:
       I added '1' as an equivalent to 'True', but I think technically users can also use other values such as 4, 123, although i doubt they would actually use it that way




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org