You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2023/01/04 18:37:58 UTC
[GitHub] [yunikorn-core] pbacsko opened a new pull request, #493: [YUNIKORN-1529] Data race in TestTimeoutPlaceholderAllocReleased
pbacsko opened a new pull request, #493:
URL: https://github.com/apache/yunikorn-core/pull/493
### What is this PR for?
Data race was detected by Go in `TestTimeoutPlaceholderAllocReleased`.
Don't use unlocked access to `Application.placeholderTimer`.
### What type of PR is it?
* [x] - Bug Fix
* [ ] - Improvement
* [ ] - Feature
* [ ] - Documentation
* [ ] - Hot Fix
* [ ] - Refactoring
### Todos
* [ ] - Task
### What is the Jira issue?
* Open an issue on Jira https://issues.apache.org/jira/browse/YUNIKORN/
* Put link here, and add [YUNIKORN-*Jira number*] in PR title, eg. `[YUNIKORN-2] Gang scheduling interface parameters`
### How should this be tested?
### Screenshots (if appropriate)
### Questions:
* [ ] - The licenses files need update.
* [ ] - There is breaking changes for older versions.
* [ ] - It needs documentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-core] wilfred-s closed pull request #493: [YUNIKORN-1529] Data race in TestTimeoutPlaceholderAllocReleased
Posted by GitBox <gi...@apache.org>.
wilfred-s closed pull request #493: [YUNIKORN-1529] Data race in TestTimeoutPlaceholderAllocReleased
URL: https://github.com/apache/yunikorn-core/pull/493
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-core] codecov[bot] commented on pull request #493: [YUNIKORN-1529] Data race in TestTimeoutPlaceholderAllocReleased
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #493:
URL: https://github.com/apache/yunikorn-core/pull/493#issuecomment-1371288511
# [Codecov](https://codecov.io/gh/apache/yunikorn-core/pull/493?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#493](https://codecov.io/gh/apache/yunikorn-core/pull/493?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6baf93a) into [master](https://codecov.io/gh/apache/yunikorn-core/commit/ef3f0c7a10b5c5362f327ba9a84b463910a2b138?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ef3f0c7) will **not change** coverage.
> The diff coverage is `n/a`.
> :exclamation: Current head 6baf93a differs from pull request most recent head a2737c9. Consider uploading reports for the commit a2737c9 to get more accurate results
```diff
@@ Coverage Diff @@
## master #493 +/- ##
=======================================
Coverage 73.07% 73.07%
=======================================
Files 69 69
Lines 10371 10371
=======================================
Hits 7579 7579
Misses 2544 2544
Partials 248 248
```
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org