You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2022/10/28 08:02:45 UTC
[GitHub] [druid] gianm opened a new pull request, #13272: MSQ: Use long instead of double for estimatedRetainedBytes.
gianm opened a new pull request, #13272:
URL: https://github.com/apache/druid/pull/13272
Fixes a problem where, due to the inexactness of floating-point math, we would potentially drift while tracking retained byte counts and run into assertion failures in `assertRetainedByteCountsAreTrackedCorrectly`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] gianm merged pull request #13272: MSQ: Use long instead of double for estimatedRetainedBytes.
Posted by GitBox <gi...@apache.org>.
gianm merged PR #13272:
URL: https://github.com/apache/druid/pull/13272
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] lgtm-com[bot] commented on pull request #13272: MSQ: Use long instead of double for estimatedRetainedBytes.
Posted by GitBox <gi...@apache.org>.
lgtm-com[bot] commented on PR #13272:
URL: https://github.com/apache/druid/pull/13272#issuecomment-1294756291
This pull request **introduces 4 alerts** when merging 48e465cd89159532f4a54b38b90afa73c54020f7 into 4775427e2c77840c19e1d2458b7e0bb0d01e76d8 - [view on LGTM.com](https://lgtm.com/projects/g/apache/druid/rev/pr-f60b1b05bb74f7fbe7acb8b5d63b78f794b37a82)
**new alerts:**
* 4 for Implicit narrowing conversion in compound assignment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org