You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Ashutosh Mestry <am...@hortonworks.com> on 2017/04/04 22:15:52 UTC

Review Request 58189: Export & Import: Documentation Updated

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58189/
-----------------------------------------------------------

Review request for atlas and Madhan Neethiraj.


Bugs: ATLAS-1717
    https://issues.apache.org/jira/browse/ATLAS-1717


Repository: atlas


Description
-------

**Approach**
Added new files to _docs_ project.

Updated pages:
http://localhost:8080/

New links:
http://localhost:8080/Import-Export-API.html
http://localhost:8080/Export-API.html
http://localhost:8080/Export-HDFS-API.html
http://localhost:8080/Import-API.html


Diffs
-----

  docs/src/site/twiki/Export-API.twiki PRE-CREATION 
  docs/src/site/twiki/Export-HDFS-API.twiki PRE-CREATION 
  docs/src/site/twiki/Import-API.twiki PRE-CREATION 
  docs/src/site/twiki/Import-Export-API.twiki PRE-CREATION 
  docs/src/site/twiki/index.twiki 8a8626f5 


Diff: https://reviews.apache.org/r/58189/diff/1/


Testing
-------

Buid steps:
- cd docs
- mvn compile
- mvn site:run
- Open http://localhost:8080 (Ensure that no server with Ambari is running).

Navigate to the new pages from home page.
Check links within the individual pages.


Thanks,

Ashutosh Mestry


Re: Review Request 58189: Export & Import: Documentation Updated

Posted by Ashutosh Mestry <am...@hortonworks.com>.

> On April 6, 2017, 3:44 p.m., Ayub Pathan wrote:
> > docs/src/site/twiki/Export-API.twiki
> > Lines 26 (patched)
> > <https://reviews.apache.org/r/58189/diff/1/?file=1684585#file1684585line26>
> >
> >     Are these additional options available for both hive_db and hdfs_path?

These options apply for all entities not limited to _hive_db_ and _hdfs_path_. In short, yes for both. The match option was added primarily to take care of HDFS paths. But they ended up being useful for all entities.


- Ashutosh


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58189/#review171215
-----------------------------------------------------------


On April 4, 2017, 10:17 p.m., Ashutosh Mestry wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58189/
> -----------------------------------------------------------
> 
> (Updated April 4, 2017, 10:17 p.m.)
> 
> 
> Review request for atlas and Madhan Neethiraj.
> 
> 
> Bugs: ATLAS-1717
>     https://issues.apache.org/jira/browse/ATLAS-1717
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> **Approach**
> Added new files to _docs_ project.
> 
> **Scope**
> Updated _docs_ project.
> Did not update _enunciate.xml_ as admin package was not included.
> 
> Updated pages:
> http://localhost:8080/
> 
> New links:
> http://localhost:8080/Import-Export-API.html
> http://localhost:8080/Export-API.html
> http://localhost:8080/Export-HDFS-API.html
> http://localhost:8080/Import-API.html
> 
> 
> Diffs
> -----
> 
>   docs/src/site/twiki/Export-API.twiki PRE-CREATION 
>   docs/src/site/twiki/Export-HDFS-API.twiki PRE-CREATION 
>   docs/src/site/twiki/Import-API.twiki PRE-CREATION 
>   docs/src/site/twiki/Import-Export-API.twiki PRE-CREATION 
>   docs/src/site/twiki/index.twiki 8a8626f5 
> 
> 
> Diff: https://reviews.apache.org/r/58189/diff/1/
> 
> 
> Testing
> -------
> 
> Buid steps:
> - cd docs
> - mvn compile
> - mvn site:run
> - Open http://localhost:8080 (Ensure that no server with Ambari is running).
> 
> Navigate to the new pages from home page.
> Check links within the individual pages.
> 
> 
> Thanks,
> 
> Ashutosh Mestry
> 
>


Re: Review Request 58189: Export & Import: Documentation Updated

Posted by Ayub Pathan <ar...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58189/#review171215
-----------------------------------------------------------




docs/src/site/twiki/Export-API.twiki
Lines 26 (patched)
<https://reviews.apache.org/r/58189/#comment244093>

    Are these additional options available for both hive_db and hdfs_path?



docs/src/site/twiki/Export-API.twiki
Lines 49 (patched)
<https://reviews.apache.org/r/58189/#comment244091>

    Will it helpful to add examples of json files explaining the content details?



docs/src/site/twiki/Import-API.twiki
Lines 61 (patched)
<https://reviews.apache.org/r/58189/#comment244092>

    Can you please add an example of import API response JSON? This might be helpful for the end user to assimilate the API.


- Ayub Pathan


On April 4, 2017, 10:17 p.m., Ashutosh Mestry wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58189/
> -----------------------------------------------------------
> 
> (Updated April 4, 2017, 10:17 p.m.)
> 
> 
> Review request for atlas and Madhan Neethiraj.
> 
> 
> Bugs: ATLAS-1717
>     https://issues.apache.org/jira/browse/ATLAS-1717
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> **Approach**
> Added new files to _docs_ project.
> 
> **Scope**
> Updated _docs_ project.
> Did not update _enunciate.xml_ as admin package was not included.
> 
> Updated pages:
> http://localhost:8080/
> 
> New links:
> http://localhost:8080/Import-Export-API.html
> http://localhost:8080/Export-API.html
> http://localhost:8080/Export-HDFS-API.html
> http://localhost:8080/Import-API.html
> 
> 
> Diffs
> -----
> 
>   docs/src/site/twiki/Export-API.twiki PRE-CREATION 
>   docs/src/site/twiki/Export-HDFS-API.twiki PRE-CREATION 
>   docs/src/site/twiki/Import-API.twiki PRE-CREATION 
>   docs/src/site/twiki/Import-Export-API.twiki PRE-CREATION 
>   docs/src/site/twiki/index.twiki 8a8626f5 
> 
> 
> Diff: https://reviews.apache.org/r/58189/diff/1/
> 
> 
> Testing
> -------
> 
> Buid steps:
> - cd docs
> - mvn compile
> - mvn site:run
> - Open http://localhost:8080 (Ensure that no server with Ambari is running).
> 
> Navigate to the new pages from home page.
> Check links within the individual pages.
> 
> 
> Thanks,
> 
> Ashutosh Mestry
> 
>


Re: Review Request 58189: Export & Import: Documentation Updated

Posted by Apoorv Naik <na...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58189/#review171774
-----------------------------------------------------------


Ship it!




Ship It!

- Apoorv Naik


On April 4, 2017, 10:17 p.m., Ashutosh Mestry wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58189/
> -----------------------------------------------------------
> 
> (Updated April 4, 2017, 10:17 p.m.)
> 
> 
> Review request for atlas and Madhan Neethiraj.
> 
> 
> Bugs: ATLAS-1717
>     https://issues.apache.org/jira/browse/ATLAS-1717
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> **Approach**
> Added new files to _docs_ project.
> 
> **Scope**
> Updated _docs_ project.
> Did not update _enunciate.xml_ as admin package was not included.
> 
> Updated pages:
> http://localhost:8080/
> 
> New links:
> http://localhost:8080/Import-Export-API.html
> http://localhost:8080/Export-API.html
> http://localhost:8080/Export-HDFS-API.html
> http://localhost:8080/Import-API.html
> 
> 
> Diffs
> -----
> 
>   docs/src/site/twiki/Export-API.twiki PRE-CREATION 
>   docs/src/site/twiki/Export-HDFS-API.twiki PRE-CREATION 
>   docs/src/site/twiki/Import-API.twiki PRE-CREATION 
>   docs/src/site/twiki/Import-Export-API.twiki PRE-CREATION 
>   docs/src/site/twiki/index.twiki 8a8626f5 
> 
> 
> Diff: https://reviews.apache.org/r/58189/diff/2/
> 
> 
> Testing
> -------
> 
> Buid steps:
> - cd docs
> - mvn compile
> - mvn site:run
> - Open http://localhost:8080 (Ensure that no server with Ambari is running).
> 
> Navigate to the new pages from home page.
> Check links within the individual pages.
> 
> 
> Thanks,
> 
> Ashutosh Mestry
> 
>


Re: Review Request 58189: Export & Import: Documentation Updated

Posted by Ashutosh Mestry <am...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58189/
-----------------------------------------------------------

(Updated April 4, 2017, 10:17 p.m.)


Review request for atlas and Madhan Neethiraj.


Changes
-------

Added scope section.


Bugs: ATLAS-1717
    https://issues.apache.org/jira/browse/ATLAS-1717


Repository: atlas


Description (updated)
-------

**Approach**
Added new files to _docs_ project.

**Scope**
Updated _docs_ project.
Did not update _enunciate.xml_ as admin package was not included.

Updated pages:
http://localhost:8080/

New links:
http://localhost:8080/Import-Export-API.html
http://localhost:8080/Export-API.html
http://localhost:8080/Export-HDFS-API.html
http://localhost:8080/Import-API.html


Diffs
-----

  docs/src/site/twiki/Export-API.twiki PRE-CREATION 
  docs/src/site/twiki/Export-HDFS-API.twiki PRE-CREATION 
  docs/src/site/twiki/Import-API.twiki PRE-CREATION 
  docs/src/site/twiki/Import-Export-API.twiki PRE-CREATION 
  docs/src/site/twiki/index.twiki 8a8626f5 


Diff: https://reviews.apache.org/r/58189/diff/1/


Testing
-------

Buid steps:
- cd docs
- mvn compile
- mvn site:run
- Open http://localhost:8080 (Ensure that no server with Ambari is running).

Navigate to the new pages from home page.
Check links within the individual pages.


Thanks,

Ashutosh Mestry