You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by fujunwei <gi...@git.apache.org> on 2015/08/31 04:40:11 UTC
[GitHub] cordova-android pull request: The extra digit need to be added to ...
GitHub user fujunwei opened a pull request:
https://github.com/apache/cordova-android/pull/211
The extra digit need to be added to the end of the version code
The version code of default config is generated by the environment variable
and the value from AndroidManifest.xml.
The test case is using the command line "cordova build -- --versionCode=100".
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/fujunwei/cordova-android version-code
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-android/pull/211.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #211
----
commit 3bee4548f3485a9a3dfbde91d162fd6c3015c458
Author: fujunwei <ju...@intel.com>
Date: 2015-08-31T02:27:33Z
The extra digit need to be added to the end of the version code
The version code of default config is generated by the environment variable
and the value from AndroidManifest.xml.
The test case is using the command line "cordova build -- --versionCode=100".
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-android pull request: The extra digit need to be added to ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-android/pull/211
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-android pull request: The extra digit need to be added to ...
Posted by huningxin <gi...@git.apache.org>.
Github user huningxin commented on the pull request:
https://github.com/apache/cordova-android/pull/211#issuecomment-136238768
LGTM. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-android pull request: The extra digit need to be added to ...
Posted by fujunwei <gi...@git.apache.org>.
Github user fujunwei commented on the pull request:
https://github.com/apache/cordova-android/pull/211#issuecomment-136238067
@huningxin @infil00p PTAL, thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-android pull request: The extra digit need to be added to ...
Posted by fujunwei <gi...@git.apache.org>.
Github user fujunwei commented on the pull request:
https://github.com/apache/cordova-android/pull/211#issuecomment-136538202
@agrieve
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org