[jira] [Comment Edited] (CALCITE-4548) SqlToRelConverter#convertExpression can not convert SqlNode which has subQuery

["Danny Chen (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CALCITE-4548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17342455#comment-17342455 ] 

Danny Chen edited comment on CALCITE-4548 at 5/11/21, 9:40 AM:
---------------------------------------------------------------

Fixed in [796675c|https://github.com/apache/calcite/commit/796675c9b33e0461bc45a72780162d474a4b098b], thanks for the PR, [~yr] ~


was (Author: danny0405):
Fixed in [796675c|[https://github.com/apache/calcite/commit/796675c9b33e0461bc45a72780162d474a4b098b],] thanks for the PR, [~yr] ~

> SqlToRelConverter#convertExpression can not convert SqlNode which has subQuery
> ------------------------------------------------------------------------------
>
>                 Key: CALCITE-4548
>                 URL: https://issues.apache.org/jira/browse/CALCITE-4548
>             Project: Calcite
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 1.26.0
>            Reporter: jibiyr
>            Assignee: jibiyr
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: next
>
>          Time Spent: 3.5h
>  Remaining Estimate: 0h
>
> hi community, when I use  *SqlToRelConverter* to convertExpression,I found it does  not registery subQuery before convertExpression, so the convertExpression throw npe.
> here is the executable example
>  
> {code:java}
> // code placeholder
> CalciterHelper calciterHelper = new CalciterHelper(config);
> SqlNode parse = calciterHelper.parseExpression("ID IN (1, 2, 3)");
> HashMap<String, RexNode> nameToNodeMap = new HashMap<>();
> nameToNodeMap.put("ID",new RexInputRef(0, calciterHelper.getTypeFactory().createSqlType(SqlTypeName.INTEGER)));
> final Map<String, RelDataType> nameToTypeMap = new HashMap<>();
> for (Map.Entry<String, RexNode> entry : nameToNodeMap.entrySet()) {
>   nameToTypeMap.put(entry.getKey(), entry.getValue().getType());
> }
> SqlValidatorImpl orCreateValidator = calciterHelper.getOrCreateValidator();
> orCreateValidator.validateCall((SqlCall) parse,new ParameterScope(orCreateValidator,nameToTypeMap));
> SqlToRelConverter orCreateSqlToRelConverter = calciterHelper.getOrCreateSqlToRelConverter();
> orCreateSqlToRelConverter.convertExpression(parse,nameToNodeMap);
> {code}
>  
>  
> and the npe,
>  
> {code:java}
> // code placeholder
> Exception in thread "main" java.lang.NullPointerExceptionException in thread "main" java.lang.NullPointerException 
> at java.util.Objects.requireNonNull(Objects.java:203) 
> at org.apache.calcite.sql2rel.SqlToRelConverter$Blackboard.convertExpression(SqlToRelConverter.java:4914)
> {code}
>  
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)