You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@giraph.apache.org by "Nitay Joffe (JIRA)" <ji...@apache.org> on 2013/04/10 00:48:17 UTC
[jira] [Updated] (GIRAPH-595) InternalVertexRunner.run() should
take GiraphConfiguration, not GiraphClasses
[ https://issues.apache.org/jira/browse/GIRAPH-595?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nitay Joffe updated GIRAPH-595:
-------------------------------
Description:
The current way GiraphClasses is used is not ideal for two reasons:
1) InternalVertexRunner has to add all those wrapper calls like conf.setXXXClass(classes.getXXXClass()). This is verbose and fragile since it has to be updated every time we add a new type of class.
2) The configuration flow is circular: the user creates a GiraphClasses, which is used to create GiraphConfiguration, which is used to create ImmutableClassesGiraphConfiguration, which creates a new GiraphClasses!
https://reviews.apache.org/r/10387/
was:
The current way GiraphClasses is used is not ideal for two reasons:
1) InternalVertexRunner has to add all those wrapper calls like conf.setXXXClass(classes.getXXXClass()). This is verbose and fragile since it has to be updated every time we add a new type of class.
2) The configuration flow is circular: the user creates a GiraphClasses, which is used to create GiraphConfiguration, which is used to create ImmutableClassesGiraphConfiguration, which creates a new GiraphClasses!
> InternalVertexRunner.run() should take GiraphConfiguration, not GiraphClasses
> -----------------------------------------------------------------------------
>
> Key: GIRAPH-595
> URL: https://issues.apache.org/jira/browse/GIRAPH-595
> Project: Giraph
> Issue Type: Bug
> Reporter: Alessandro Presta
> Assignee: Nitay Joffe
>
> The current way GiraphClasses is used is not ideal for two reasons:
> 1) InternalVertexRunner has to add all those wrapper calls like conf.setXXXClass(classes.getXXXClass()). This is verbose and fragile since it has to be updated every time we add a new type of class.
> 2) The configuration flow is circular: the user creates a GiraphClasses, which is used to create GiraphConfiguration, which is used to create ImmutableClassesGiraphConfiguration, which creates a new GiraphClasses!
> https://reviews.apache.org/r/10387/
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira