You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by me...@apache.org on 2018/09/05 20:55:29 UTC
[beam-site] branch asf-site updated (2aca6fa -> 5a00fd9)
This is an automated email from the ASF dual-hosted git repository.
mergebot-role pushed a change to branch asf-site
in repository https://gitbox.apache.org/repos/asf/beam-site.git.
from 2aca6fa Prepare repository for deployment.
add f1dcace Contribute: document how to find and add reviewers
add 49563e7 This closes #545
new 5a00fd9 Prepare repository for deployment.
The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
content/contribute/index.html | 36 ++++++++++++++++++++++++++++++++++++
src/contribute/index.md | 30 ++++++++++++++++++++++++++++++
2 files changed, 66 insertions(+)
[beam-site] 01/01: Prepare repository for deployment.
Posted by me...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
mergebot-role pushed a commit to branch asf-site
in repository https://gitbox.apache.org/repos/asf/beam-site.git
commit 5a00fd9a0d3de646f5a4d4cea554d3930e0231e8
Author: Mergebot <me...@apache.org>
AuthorDate: Wed Sep 5 20:55:27 2018 +0000
Prepare repository for deployment.
---
content/contribute/index.html | 36 ++++++++++++++++++++++++++++++++++++
1 file changed, 36 insertions(+)
diff --git a/content/contribute/index.html b/content/contribute/index.html
index c6f1426..b2767bf 100644
--- a/content/contribute/index.html
+++ b/content/contribute/index.html
@@ -207,6 +207,12 @@
<li><a href="#developing-with-the-python-sdk">Developing with the Python SDK</a></li>
</ul>
</li>
+ <li><a href="#reviews">Reviews</a>
+ <ul>
+ <li><a href="#finding-reviewers">Finding reviewers</a></li>
+ <li><a href="#adding-yourself-as-a-reviewer">Adding yourself as a reviewer</a></li>
+ </ul>
+ </li>
<li><a href="#contributing-to-the-website">Contributing to the website</a></li>
<li><a href="#works-in-progress">Works in progress</a>
<ul>
@@ -479,6 +485,36 @@ $ python setup.py sdist
</code></pre>
</div>
+<h2 id="reviews">Reviews</h2>
+
+<p>Reviewers for <a href="https://github.com/apache/beam">apache/beam</a> are listed in
+Prow-style OWNERS files. A description of these files can be found
+<a href="https://go.k8s.io/owners">here</a>.</p>
+
+<h3 id="finding-reviewers">Finding reviewers</h3>
+
+<p>Currently this is a manual process. Tracking bug for automating this:
+<a href="https://issues.apache.org/jira/browse/BEAM-4790">BEAM-4790</a>.</p>
+
+<p>For each file to be reviewed, look for an OWNERS file in its directory. Pick a
+single reviewer from that file. If the directory doesn’t contain an OWNERS file,
+go up a directory. Keep going until you find one. Try to limit the number of
+reviewers to 2 per PR if possible, to minimize reviewer load.</p>
+
+<h3 id="adding-yourself-as-a-reviewer">Adding yourself as a reviewer</h3>
+
+<p>Find the deepest sub-directory that contains the files you want to be a reviewer
+for and add your Github username under <code class="highlighter-rouge">reviewers</code> in the OWNERS file (create a
+new OWNERS file if necessary).</p>
+
+<p>The Beam project currently only uses the <code class="highlighter-rouge">reviewers</code> key in OWNERS and no other
+features, as reviewer selection is still a manual process.</p>
+
+<!-- TODO(BEAM-4790): If Prow write access gets approved
+(https://issues.apache.org/jira/browse/INFRA-16869), document that if you are
+not a committer you can still be listed as a reviewer. Just ask to get added as
+a read-only collaborator to apache/beam by opening an INFRA ticket. -->
+
<h2 id="contributing-to-the-website">Contributing to the website</h2>
<p>The Beam website is in the <a href="https://github.com/apache/beam-site">Beam Site GitHub