You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2022/10/21 20:28:00 UTC
[jira] [Work logged] (GOBBLIN-1732) Search for dummy file in writer directory
[ https://issues.apache.org/jira/browse/GOBBLIN-1732?focusedWorklogId=819265&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-819265 ]
ASF GitHub Bot logged work on GOBBLIN-1732:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 21/Oct/22 20:27
Start Date: 21/Oct/22 20:27
Worklog Time Spent: 10m
Work Description: jack-moseley opened a new pull request, #3589:
URL: https://github.com/apache/gobblin/pull/3589
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
### JIRA
- [x] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-1732
### Description
- [x] Here are some details about my PR, including screenshots (if applicable):
Before, when sending change_property events, the GMCE publisher searches in the top level dataset directory for an example file. This could find files with other schemas/paths if there are different directories in the dataset directory. This PR changes it to search under the `TimeBasedWriterPartitioner.WRITER_PARTITION_PREFIX` folder if that config exists to avoid this.
Also, there was no reason why there was a list/for loop here before, because `ConfigurationKeys.DATA_PUBLISHER_DATASET_DIR` is a single path, so the for loop has been removed.
### Tests
- [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
Updated unit test
### Commits
- [x] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
Issue Time Tracking
-------------------
Worklog Id: (was: 819265)
Remaining Estimate: 0h
Time Spent: 10m
> Search for dummy file in writer directory
> -----------------------------------------
>
> Key: GOBBLIN-1732
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1732
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Jack Moseley
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)