You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by "Zhe (Joe) Wang" <jw...@hortonworks.com> on 2016/03/08 01:50:48 UTC
Review Request 44487: AMBARI-15327 Combo Search: Query for multiple
facets
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44487/
-----------------------------------------------------------
Review request for Ambari, Jaimin Jetly, Richard Zang, Srimanth Gunturi, Xi Wang, and Yusaku Sako.
Bugs: AMBARI-15327
https://issues.apache.org/jira/browse/AMBARI-15327
Repository: ambari
Description
-------
Currently we allow only one component state facet but <Component:Any> can be supported using .in(). Add query support for multiple <Component:Any> facet.
Diffs
-----
ambari-web/app/controllers/main/host/combo_search_box.js 9fa6851
Diff: https://reviews.apache.org/r/44487/diff/
Testing
-------
Local ambari-web test passed.
24565 tests complete (21 seconds)
145 tests pending
Manual testing done.
Thanks,
Zhe (Joe) Wang
Re: Review Request 44487: AMBARI-15327 Combo Search: Query for
multiple
facets and display label instead of value in search box
Posted by Richard Zang <rz...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44487/#review122782
-----------------------------------------------------------
Ship it!
Ship It!
- Richard Zang
On March 9, 2016, 2:20 a.m., Zhe (Joe) Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44487/
> -----------------------------------------------------------
>
> (Updated March 9, 2016, 2:20 a.m.)
>
>
> Review request for Ambari, Jaimin Jetly, Richard Zang, Srimanth Gunturi, Xi Wang, and Yusaku Sako.
>
>
> Bugs: AMBARI-15327
> https://issues.apache.org/jira/browse/AMBARI-15327
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Currently we allow only one component state facet but <Component:Any> can be supported using .in(). Add query support for multiple <Component:Any> facet.
> Display label instead of value in search box
>
>
> Diffs
> -----
>
> ambari-web/app/controllers/main/host.js b473c59
> ambari-web/app/controllers/main/host/combo_search_box.js 9fa6851
> ambari-web/app/mixins/common/table_server_view_mixin.js eca17d6
> ambari-web/app/views/main/host/combo_search_box.js 17c0a6d
> ambari-web/test/controllers/main/host_test.js 06a4813
>
> Diff: https://reviews.apache.org/r/44487/diff/
>
>
> Testing
> -------
>
> Modified unit test. Local ambari-web test passed.
> 24565 tests complete (21 seconds)
> 145 tests pending
> Manual testing done.
>
>
> Thanks,
>
> Zhe (Joe) Wang
>
>
Re: Review Request 44487: AMBARI-15327 Combo Search: Query for
multiple
facets and display label instead of value in search box
Posted by "Zhe (Joe) Wang" <jw...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44487/
-----------------------------------------------------------
(Updated March 9, 2016, 2:20 a.m.)
Review request for Ambari, Jaimin Jetly, Richard Zang, Srimanth Gunturi, Xi Wang, and Yusaku Sako.
Summary (updated)
-----------------
AMBARI-15327 Combo Search: Query for multiple <Component:Any> facets and display label instead of value in search box
Bugs: AMBARI-15327
https://issues.apache.org/jira/browse/AMBARI-15327
Repository: ambari
Description
-------
Currently we allow only one component state facet but <Component:Any> can be supported using .in(). Add query support for multiple <Component:Any> facet.
Display label instead of value in search box
Diffs
-----
ambari-web/app/controllers/main/host.js b473c59
ambari-web/app/controllers/main/host/combo_search_box.js 9fa6851
ambari-web/app/mixins/common/table_server_view_mixin.js eca17d6
ambari-web/app/views/main/host/combo_search_box.js 17c0a6d
ambari-web/test/controllers/main/host_test.js 06a4813
Diff: https://reviews.apache.org/r/44487/diff/
Testing
-------
Modified unit test. Local ambari-web test passed.
24565 tests complete (21 seconds)
145 tests pending
Manual testing done.
Thanks,
Zhe (Joe) Wang
Re: Review Request 44487: Combo Search: Query for multiple
facets and display label instead of value in search box
Posted by "Zhe (Joe) Wang" <jw...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44487/
-----------------------------------------------------------
(Updated March 9, 2016, 2:19 a.m.)
Review request for Ambari, Jaimin Jetly, Richard Zang, Srimanth Gunturi, Xi Wang, and Yusaku Sako.
Summary (updated)
-----------------
Combo Search: Query for multiple <Component:Any> facets and display label instead of value in search box
Bugs: AMBARI-15327
https://issues.apache.org/jira/browse/AMBARI-15327
Repository: ambari
Description (updated)
-------
Currently we allow only one component state facet but <Component:Any> can be supported using .in(). Add query support for multiple <Component:Any> facet.
Display label instead of value in search box
Diffs
-----
ambari-web/app/controllers/main/host.js b473c59
ambari-web/app/controllers/main/host/combo_search_box.js 9fa6851
ambari-web/app/mixins/common/table_server_view_mixin.js eca17d6
ambari-web/app/views/main/host/combo_search_box.js 17c0a6d
ambari-web/test/controllers/main/host_test.js 06a4813
Diff: https://reviews.apache.org/r/44487/diff/
Testing (updated)
-------
Modified unit test. Local ambari-web test passed.
24565 tests complete (21 seconds)
145 tests pending
Manual testing done.
Thanks,
Zhe (Joe) Wang
Re: Review Request 44487: AMBARI-15327 Combo Search: Query for
multiple facets
Posted by "Zhe (Joe) Wang" <jw...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44487/
-----------------------------------------------------------
(Updated March 9, 2016, 2:14 a.m.)
Review request for Ambari, Jaimin Jetly, Richard Zang, Srimanth Gunturi, Xi Wang, and Yusaku Sako.
Bugs: AMBARI-15327
https://issues.apache.org/jira/browse/AMBARI-15327
Repository: ambari
Description
-------
Currently we allow only one component state facet but <Component:Any> can be supported using .in(). Add query support for multiple <Component:Any> facet.
Diffs (updated)
-----
ambari-web/app/controllers/main/host.js b473c59
ambari-web/app/controllers/main/host/combo_search_box.js 9fa6851
ambari-web/app/mixins/common/table_server_view_mixin.js eca17d6
ambari-web/app/views/main/host/combo_search_box.js 17c0a6d
ambari-web/test/controllers/main/host_test.js 06a4813
Diff: https://reviews.apache.org/r/44487/diff/
Testing (updated)
-------
Modified unit test. Local ambari-web test passed.
24557 tests complete (21 seconds)
146 tests pending
Manual testing done.
Thanks,
Zhe (Joe) Wang