You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Daniel Rall <dl...@collab.net> on 2007/11/08 17:44:33 UTC
Re: svn commit: r27713 - trunk/subversion/tests/libsvn_subr
On Thu, 08 Nov 2007, pburba@tigris.org wrote:
...
> --- trunk/subversion/tests/libsvn_subr/mergeinfo-test.c (original)
> +++ trunk/subversion/tests/libsvn_subr/mergeinfo-test.c Thu Nov 8 09:08:34 2007
...
> -#define NBR_MERGEINFO_VALS 3
> +#define NBR_MERGEINFO_VALS 5
> /* Valid mergeinfo values. */
> static const char * const mergeinfo_vals[NBR_MERGEINFO_VALS] =
> {
> "/trunk:1",
> "/trunk/foo:1-6",
> - "/trunk: 5,7-9,10,11,13,14"
> + "/trunk: 5,7-9,10,11,13,14",
> + "/trunk: 3-10,11*,13,14",
> + "/branch: 1,2-18*,33*"
> + /* ### Should svn_mergeinfo_parse() handle unordered
> + ### but otherwise valid input strings like this?
> + ### Currently this fails.
> + /* "/trunk: 7-9,5,10,14,13,11" */
> };
svn_mergeinfo_parse() was never intended to handle unordered
rangelists. Its doc string doesn't currently reflect this, but
probably should.
RE: Re: svn commit: r27713 - trunk/subversion/tests/libsvn_subr
Posted by Paul Burba <pb...@collab.net>.
> -----Original Message-----
> From: Daniel Rall [mailto:dlr@collab.net]
> Sent: Thursday, November 08, 2007 12:45 PM
> To: dev@subversion.tigris.org; pburba@tigris.org
> Cc: svn@subversion.tigris.org
> Subject: Re: svn commit: r27713 - trunk/subversion/tests/libsvn_subr
>
> On Thu, 08 Nov 2007, pburba@tigris.org wrote:
> ...
> > --- trunk/subversion/tests/libsvn_subr/mergeinfo-test.c
> (original)
> > +++ trunk/subversion/tests/libsvn_subr/mergeinfo-test.c
> Thu Nov 8 09:08:34 2007
> ...
> > -#define NBR_MERGEINFO_VALS 3
> > +#define NBR_MERGEINFO_VALS 5
> > /* Valid mergeinfo values. */
> > static const char * const mergeinfo_vals[NBR_MERGEINFO_VALS] =
> > {
> > "/trunk:1",
> > "/trunk/foo:1-6",
> > - "/trunk: 5,7-9,10,11,13,14"
> > + "/trunk: 5,7-9,10,11,13,14",
> > + "/trunk: 3-10,11*,13,14",
> > + "/branch: 1,2-18*,33*"
> > + /* ### Should svn_mergeinfo_parse() handle unordered
> > + ### but otherwise valid input strings like this?
> > + ### Currently this fails.
> > + /* "/trunk: 7-9,5,10,14,13,11" */
> > };
>
> svn_mergeinfo_parse() was never intended to handle unordered
> rangelists. Its doc string doesn't currently reflect this,
> but probably should.
Music to my ears.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org