You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@arrow.apache.org by GitBox <gi...@apache.org> on 2022/08/02 15:00:53 UTC

[GitHub] [arrow-nanoarrow] paleolimbot opened a new pull request, #9: Attempt memcheck + suppressions

paleolimbot opened a new pull request, #9:
URL: https://github.com/apache/arrow-nanoarrow/pull/9

   Fixes #7


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow-nanoarrow] paleolimbot merged pull request #9: Attempt memcheck + suppressions

Posted by GitBox <gi...@apache.org>.
paleolimbot merged PR #9:
URL: https://github.com/apache/arrow-nanoarrow/pull/9


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow-nanoarrow] paleolimbot commented on a diff in pull request #9: Attempt memcheck + suppressions

Posted by GitBox <gi...@apache.org>.
paleolimbot commented on code in PR #9:
URL: https://github.com/apache/arrow-nanoarrow/pull/9#discussion_r935736791


##########
.github/workflows/build-and-test.yaml:
##########
@@ -106,7 +106,7 @@ jobs:
       - name: Run tests with valgrind
         run: |
           cd build
-          valgrind --tool=memcheck --leak-check=full ctest -T test .
+          ctest -T memcheck .

Review Comment:
   🤷 I just google this stuff!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow-nanoarrow] pitrou commented on a diff in pull request #9: Attempt memcheck + suppressions

Posted by GitBox <gi...@apache.org>.
pitrou commented on code in PR #9:
URL: https://github.com/apache/arrow-nanoarrow/pull/9#discussion_r935729152


##########
.github/workflows/build-and-test.yaml:
##########
@@ -106,7 +106,7 @@ jobs:
       - name: Run tests with valgrind
         run: |
           cd build
-          valgrind --tool=memcheck --leak-check=full ctest -T test .
+          ctest -T memcheck .

Review Comment:
   Is this actually built into ctest? I had no idea.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org