You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@opendal.apache.org by "Lstarsky0 (via GitHub)" <gi...@apache.org> on 2026/08/17 11:15:22 UTC
[PR] fix(core): enable tokio/time in dev-dependencies so the crate's tests compile [opendal]
Lstarsky0 opened a new pull request, #8103:
URL: https://github.com/apache/opendal/pull/8103
# Which issue does this PR close?
None. The same dev-dependency line already exists on #8042, a much larger transport change that is currently conflicting; this splits the build fix out so it can land on its own.
# Rationale for this change
`cargo test -p opendal-core` does not compile on any non-wasm target:
```
error[E0432]: unresolved import `tokio::time`
--> core/src/types/execute/executors/tokio_executor.rs:38:16
|
38 | use tokio::time::sleep;
| ^^^^ could not find `time` in `tokio`
```
Ten sites across seven files use `tokio::time`, all of them inside `mod tests`, but the `time` feature is only enabled under `[target.'cfg(target_arch = "wasm32")'.dependencies]`. Core CI runs `--workspace --all-features`, where feature unification pulls `tokio/time` in from siblings such as `opendal-layer-timeout`, so the gap only shows up when the crate is built on its own.
# What changes are included in this PR?
Add `"time"` to the `tokio` entry in `[dev-dependencies]`. The line crossed 80 columns, so `taplo format` expanded the array.
# Are there any user-facing changes?
No. Dev-dependencies are not part of the published build, and `Cargo.lock` is unchanged. `cargo test -p opendal-core` now runs 183 unit tests and 130 doc tests.
# AI Usage Statement
AI assisted with investigating the build failure and drafting this description. I reviewed and take responsibility for the change. There are no known assumptions or unknowns that affect review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(core): add missing tokio test features so crates build on their own [opendal]
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo merged PR #8103:
URL: https://github.com/apache/opendal/pull/8103
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org