[GitHub] [beam] aromanenko-dev commented on a diff in pull request #22584: [CdapIO] Integration CdapIO with SparkReceiverIO

[GitBox <gi...@apache.org>]

aromanenko-dev commented on code in PR #22584:
URL: https://github.com/apache/beam/pull/22584#discussion_r988724793


##########
sdks/java/io/cdap/build.gradle:
##########
@@ -52,14 +52,17 @@ dependencies {
     implementation library.java.cdap_plugin_zendesk
     implementation library.java.commons_lang3
     implementation library.java.guava
+    implementation library.java.google_code_gson
     implementation library.java.hadoop_common
     implementation library.java.hadoop_mapreduce_client_core
     implementation library.java.jackson_core
     implementation library.java.jackson_databind
     implementation library.java.slf4j_api
+    implementation library.java.spark_streaming

Review Comment:
   Unfortunately, I'm disagree with that, at least, for Spark v2 entities. We don't have this naming strategy for Spark runner (why? it's another question), so it will be confusing to have `spark2*` and `spark*` names in the same time. 
   
   Though, for Spark v3 we used to have `spark3` prefix, so we can continue that strategy for `spark4` and etc if it will be needed. 
   
   Actually, it looks as more wide question that can be applied for similar cases in other Beam components.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org