You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ambari.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/10/03 00:40:00 UTC

[jira] [Commented] (AMBARI-24724) Remove ambari-metrics dependency on ambari-commons

    [ https://issues.apache.org/jira/browse/AMBARI-24724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16636283#comment-16636283 ] 

ASF GitHub Bot commented on AMBARI-24724:
-----------------------------------------

swagle opened a new pull request #4: AMBARI-24724. Remove ambari-metrics dependency on ambari-commons.
URL: https://github.com/apache/ambari-metrics/pull/4
 
 
   ## What changes were proposed in this pull request?
   
   The unnecessary dep was added to support OS defaults and test functions around windows supportability added a few years back. Since then the windows support has not been supported by any developers and is no longer of any use. We recently separated the metrics repo and this dep creates a circular build time dependency.
   
   ## How was this patch tested?
   
   Ran unit tests.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Remove ambari-metrics dependency on ambari-commons
> --------------------------------------------------
>
>                 Key: AMBARI-24724
>                 URL: https://issues.apache.org/jira/browse/AMBARI-24724
>             Project: Ambari
>          Issue Type: Task
>          Components: ambari-metrics
>    Affects Versions: 2.2.0
>            Reporter: Siddharth Wagle
>            Assignee: Siddharth Wagle
>            Priority: Critical
>              Labels: pull-request-available
>             Fix For: 2.8.0
>
>
> The unnecessary dep was added to support OS defaults and test functions around windows supportability added a few years back. Since then the windows support has not been supported by any developers and is no longer of any use. We recently separated the metrics repo and this dep creates a circular build time dependency.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)