You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomee.apache.org by Svetlin Zarev <sv...@gmail.com> on 2017/07/10 11:15:33 UTC
Forgotten PRs
Hi,
Would you consider merging [1] which fixes deployment issues in case of
java 8 (it was approved by Romain last week) and [2] which adds a missing
test scope to test dependency (approved last week by Romain and
Jean-Louis).
[1] https://github.com/apache/tomee/pull/84
[2] https://github.com/apache/tomee/pull/82
Thanks,
Svetlin
Re: Forgotten PRs
Posted by Svetlin Zarev <sv...@gmail.com>.
Thank you!
2017-07-10 14:40 GMT+03:00 Jean-Louis Monteiro <jl...@tomitribe.com>:
> Done.
> Thank you
>
> --
> Jean-Louis Monteiro
> http://twitter.com/jlouismonteiro
> http://www.tomitribe.com
>
> On Mon, Jul 10, 2017 at 1:24 PM, Jean-Louis Monteiro <
> jlmonteiro@tomitribe.com> wrote:
>
> > Hi,
> >
> > Thanks for pinging us here.
> > I can merge both for you.
> >
> > Jean-Louis
> >
> > --
> > Jean-Louis Monteiro
> > http://twitter.com/jlouismonteiro
> > http://www.tomitribe.com
> >
> > On Mon, Jul 10, 2017 at 1:15 PM, Svetlin Zarev <
> > svetlin.angelov.zarev@gmail.com> wrote:
> >
> >> Hi,
> >>
> >> Would you consider merging [1] which fixes deployment issues in case of
> >> java 8 (it was approved by Romain last week) and [2] which adds a
> missing
> >> test scope to test dependency (approved last week by Romain and
> >> Jean-Louis).
> >>
> >>
> >> [1] https://github.com/apache/tomee/pull/84
> >> [2] https://github.com/apache/tomee/pull/82
> >>
> >> Thanks,
> >> Svetlin
> >>
> >
> >
>
Re: Forgotten PRs
Posted by Jean-Louis Monteiro <jl...@tomitribe.com>.
Done.
Thank you
--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com
On Mon, Jul 10, 2017 at 1:24 PM, Jean-Louis Monteiro <
jlmonteiro@tomitribe.com> wrote:
> Hi,
>
> Thanks for pinging us here.
> I can merge both for you.
>
> Jean-Louis
>
> --
> Jean-Louis Monteiro
> http://twitter.com/jlouismonteiro
> http://www.tomitribe.com
>
> On Mon, Jul 10, 2017 at 1:15 PM, Svetlin Zarev <
> svetlin.angelov.zarev@gmail.com> wrote:
>
>> Hi,
>>
>> Would you consider merging [1] which fixes deployment issues in case of
>> java 8 (it was approved by Romain last week) and [2] which adds a missing
>> test scope to test dependency (approved last week by Romain and
>> Jean-Louis).
>>
>>
>> [1] https://github.com/apache/tomee/pull/84
>> [2] https://github.com/apache/tomee/pull/82
>>
>> Thanks,
>> Svetlin
>>
>
>
Re: Forgotten PRs
Posted by Jean-Louis Monteiro <jl...@tomitribe.com>.
Hi,
Thanks for pinging us here.
I can merge both for you.
Jean-Louis
--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com
On Mon, Jul 10, 2017 at 1:15 PM, Svetlin Zarev <
svetlin.angelov.zarev@gmail.com> wrote:
> Hi,
>
> Would you consider merging [1] which fixes deployment issues in case of
> java 8 (it was approved by Romain last week) and [2] which adds a missing
> test scope to test dependency (approved last week by Romain and
> Jean-Louis).
>
>
> [1] https://github.com/apache/tomee/pull/84
> [2] https://github.com/apache/tomee/pull/82
>
> Thanks,
> Svetlin
>