You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "lianetm (via GitHub)" <gi...@apache.org> on 2025/04/29 17:32:07 UTC
[PR] MINOR: Improve docs for retries & cleanup [kafka]
lianetm opened a new pull request, #19595:
URL: https://github.com/apache/kafka/pull/19595
Improve docs for retries config, mainly to clarify the expected behaviour on retries=0
Also remove unused funcs and fix typo.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Improve docs for retries & cleanup [kafka]
Posted by "mjsax (via GitHub)" <gi...@apache.org>.
mjsax commented on code in PR #19595:
URL: https://github.com/apache/kafka/pull/19595#discussion_r2067043149
##########
clients/src/main/java/org/apache/kafka/clients/CommonClientConfigs.java:
##########
@@ -88,8 +88,9 @@ public class CommonClientConfigs {
"If provided, the backoff per host will increase exponentially for each consecutive connection failure, up to this maximum. After calculating the backoff increase, 20% random jitter is added to avoid connection storms.";
public static final String RETRIES_CONFIG = "retries";
- public static final String RETRIES_DOC = "Setting a value greater than zero will cause the client to resend any request that fails with a potentially transient error." +
- " It is recommended to set the value to either zero or `MAX_VALUE` and use corresponding timeout parameters to control how long a client should retry a request.";
+ public static final String RETRIES_DOC = "It is recommended to set the value to either `MAX_VALUE` or zero, and use corresponding timeout parameters to control how long a client should retry a request." +
Review Comment:
Hmmm... This is "common" configs; not producer. So might be ok as-is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Improve docs for retries & cleanup [kafka]
Posted by "mjsax (via GitHub)" <gi...@apache.org>.
mjsax commented on code in PR #19595:
URL: https://github.com/apache/kafka/pull/19595#discussion_r2070542742
##########
clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java:
##########
@@ -274,11 +274,12 @@ public class ProducerConfig extends AbstractConfig {
/** <code>retries</code> */
public static final String RETRIES_CONFIG = CommonClientConfigs.RETRIES_CONFIG;
- private static final String RETRIES_DOC = "Setting a value greater than zero will cause the client to resend any record whose send fails with a potentially transient error."
- + " Note that this retry is no different than if the client resent the record upon receiving the error."
- + " Produce requests will be failed before the number of retries has been exhausted if the timeout configured by"
- + " <code>" + DELIVERY_TIMEOUT_MS_CONFIG + "</code> expires first before successful acknowledgement. Users should generally"
- + " prefer to leave this config unset and instead use <code>" + DELIVERY_TIMEOUT_MS_CONFIG + "</code> to control"
+ private static final String RETRIES_DOC = "Number of times to retry a request that fails with a transient error."
+ + " Setting a value greater than zero will cause the client to resend any record whose send fails with a potentially transient error. "
+ + " Requests will be retried this many times until they succeed, fail with a non-transient error, or the <code> DELIVERY_TIMEOUT_MS_CONFIG </code> expires."
+ + " Note that this automatic retry is no different than if the client resent the record upon receiving the error."
+ + " Setting a value of zero will disable this automatic retry behaviour, so that the transient errors will be propagated to the application to be handled."
+ + " Users should generally prefer to leave this config unset and instead use <code>" + DELIVERY_TIMEOUT_MS_CONFIG + "</code> to control"
+ " retry behavior."
+ "<p>"
+ "Enabling idempotence requires this config value to be greater than 0."
Review Comment:
Thanks. Interesting.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Improve docs for retries & cleanup [kafka]
Posted by "mjsax (via GitHub)" <gi...@apache.org>.
mjsax commented on code in PR #19595:
URL: https://github.com/apache/kafka/pull/19595#discussion_r2067051594
##########
clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java:
##########
@@ -276,6 +276,7 @@ public class ProducerConfig extends AbstractConfig {
public static final String RETRIES_CONFIG = CommonClientConfigs.RETRIES_CONFIG;
private static final String RETRIES_DOC = "Setting a value greater than zero will cause the client to resend any record whose send fails with a potentially transient error."
+ " Note that this retry is no different than if the client resent the record upon receiving the error."
+ + " Setting a value of zero will make that transient errors won't be retried, and will be propagated to the application to be handled."
Review Comment:
Sounds redundant to the next sentence? `Produce requests will be failed before the number of retries has been exhausted` -- with `retries=0` is implies that transient error will be throw into the application right away, right?
I agree that the new sentence is easier to read, but should we do a larger rewrite to avoid redundancy?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Improve docs for retries & cleanup [kafka]
Posted by "mjsax (via GitHub)" <gi...@apache.org>.
mjsax commented on code in PR #19595:
URL: https://github.com/apache/kafka/pull/19595#discussion_r2067052847
##########
clients/src/main/java/org/apache/kafka/clients/CommonClientConfigs.java:
##########
@@ -88,8 +88,9 @@ public class CommonClientConfigs {
"If provided, the backoff per host will increase exponentially for each consecutive connection failure, up to this maximum. After calculating the backoff increase, 20% random jitter is added to avoid connection storms.";
public static final String RETRIES_CONFIG = "retries";
- public static final String RETRIES_DOC = "Setting a value greater than zero will cause the client to resend any request that fails with a potentially transient error." +
- " It is recommended to set the value to either zero or `MAX_VALUE` and use corresponding timeout parameters to control how long a client should retry a request.";
+ public static final String RETRIES_DOC = "It is recommended to set the value to either `MAX_VALUE` or zero, and use corresponding timeout parameters to control how long a client should retry a request." +
Review Comment:
But still -- I think the recommendation should still be `MAX_VALUE`, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Improve docs for retries & cleanup [kafka]
Posted by "mingyen066 (via GitHub)" <gi...@apache.org>.
mingyen066 commented on code in PR #19595:
URL: https://github.com/apache/kafka/pull/19595#discussion_r2068023739
##########
clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java:
##########
@@ -415,7 +415,7 @@ public KafkaProducer(Properties properties, Serializer<K> keySerializer, Seriali
this.transactionManager = configureTransactionState(config, logContext);
// There is no need to do work required for adaptive partitioning, if we use a custom partitioner.
boolean enableAdaptivePartitioning = partitionerPlugin.get() == null &&
- config.getBoolean(ProducerConfig.PARTITIONER_ADPATIVE_PARTITIONING_ENABLE_CONFIG);
Review Comment:
Someone has previously renamed this config. The earlier conclusion was that we should submit a trivial KIP to deprecate this config.
https://github.com/apache/kafka/pull/17908
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Improve docs for retries & cleanup [kafka]
Posted by "lianetm (via GitHub)" <gi...@apache.org>.
lianetm commented on code in PR #19595:
URL: https://github.com/apache/kafka/pull/19595#discussion_r2068961420
##########
clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java:
##########
@@ -100,7 +100,7 @@ public class ProducerConfig extends AbstractConfig {
+ "similar or lower producer latency despite the increased linger.";
/** <code>partitioner.adaptive.partitioning.enable</code> */
- public static final String PARTITIONER_ADPATIVE_PARTITIONING_ENABLE_CONFIG = "partitioner.adaptive.partitioning.enable";
+ public static final String PARTITIONER_ADAPTIVE_PARTITIONING_ENABLE_CONFIG = "partitioner.adaptive.partitioning.enable";
private static final String PARTITIONER_ADPATIVE_PARTITIONING_ENABLE_DOC =
Review Comment:
I'll leave of the adaptive typo changes out, it probably makes sense to address them together when the public config can be fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Improve docs for retries & cleanup [kafka]
Posted by "mingyen066 (via GitHub)" <gi...@apache.org>.
mingyen066 commented on code in PR #19595:
URL: https://github.com/apache/kafka/pull/19595#discussion_r2068023739
##########
clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java:
##########
@@ -415,7 +415,7 @@ public KafkaProducer(Properties properties, Serializer<K> keySerializer, Seriali
this.transactionManager = configureTransactionState(config, logContext);
// There is no need to do work required for adaptive partitioning, if we use a custom partitioner.
boolean enableAdaptivePartitioning = partitionerPlugin.get() == null &&
- config.getBoolean(ProducerConfig.PARTITIONER_ADPATIVE_PARTITIONING_ENABLE_CONFIG);
Review Comment:
@m1a2st found that this is public interface and I found someone has previously renamed this config. The earlier conclusion was that we should submit a trivial KIP to deprecate this config.
https://github.com/apache/kafka/pull/17908
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Improve docs for retries & cleanup [kafka]
Posted by "FrankYang0529 (via GitHub)" <gi...@apache.org>.
FrankYang0529 commented on code in PR #19595:
URL: https://github.com/apache/kafka/pull/19595#discussion_r2068047270
##########
clients/src/main/java/org/apache/kafka/clients/CommonClientConfigs.java:
##########
@@ -88,8 +88,9 @@ public class CommonClientConfigs {
"If provided, the backoff per host will increase exponentially for each consecutive connection failure, up to this maximum. After calculating the backoff increase, 20% random jitter is added to avoid connection storms.";
public static final String RETRIES_CONFIG = "retries";
- public static final String RETRIES_DOC = "Setting a value greater than zero will cause the client to resend any request that fails with a potentially transient error." +
- " It is recommended to set the value to either zero or `MAX_VALUE` and use corresponding timeout parameters to control how long a client should retry a request.";
+ public static final String RETRIES_DOC = "It is recommended to set the value to either `MAX_VALUE` or zero, and use corresponding timeout parameters to control how long a client should retry a request." +
Review Comment:
nit: We can change '\`' to `<code>`, so we can have syntax on document.
```suggestion
public static final String RETRIES_DOC = "It is recommended to set the value to either <code>MAX_VALUE</code> or zero, and use corresponding timeout parameters to control how long a client should retry a request." +
```
before:
<img width="628" alt="Screenshot 2025-04-30 at 3 24 22 PM" src="https://github.com/user-attachments/assets/0959bced-9f2f-4a1c-8e9e-2598f996f162" />
after:
<img width="634" alt="Screenshot 2025-04-30 at 3 22 56 PM" src="https://github.com/user-attachments/assets/0f6b12e6-fda5-4c28-b597-2dd7efbb081e" />
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Improve docs for retries & cleanup [kafka]
Posted by "mjsax (via GitHub)" <gi...@apache.org>.
mjsax commented on code in PR #19595:
URL: https://github.com/apache/kafka/pull/19595#discussion_r2069123242
##########
clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java:
##########
@@ -274,11 +274,12 @@ public class ProducerConfig extends AbstractConfig {
/** <code>retries</code> */
public static final String RETRIES_CONFIG = CommonClientConfigs.RETRIES_CONFIG;
- private static final String RETRIES_DOC = "Setting a value greater than zero will cause the client to resend any record whose send fails with a potentially transient error."
- + " Note that this retry is no different than if the client resent the record upon receiving the error."
- + " Produce requests will be failed before the number of retries has been exhausted if the timeout configured by"
- + " <code>" + DELIVERY_TIMEOUT_MS_CONFIG + "</code> expires first before successful acknowledgement. Users should generally"
- + " prefer to leave this config unset and instead use <code>" + DELIVERY_TIMEOUT_MS_CONFIG + "</code> to control"
+ private static final String RETRIES_DOC = "Number of times to retry a request that fails with a transient error."
+ + " Setting a value greater than zero will cause the client to resend any record whose send fails with a potentially transient error. "
+ + " Requests will be retried this many times until they succeed, fail with a non-transient error, or the <code> DELIVERY_TIMEOUT_MS_CONFIG </code> expires."
+ + " Note that this automatic retry is no different than if the client resent the record upon receiving the error."
Review Comment:
> that automatic retries won't mess around/change the request (and that would be exactly the same as if the client resent the request, without messing around with it
I am confused. I read "the client resent the request" as the application code calls `send(...)` again? Do I miss understand? If "the client resent the request" is not meaning app calls `send(...)` again, that what does it mean?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Improve docs for retries & cleanup [kafka]
Posted by "lianetm (via GitHub)" <gi...@apache.org>.
lianetm commented on code in PR #19595:
URL: https://github.com/apache/kafka/pull/19595#discussion_r2070595633
##########
clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java:
##########
@@ -274,11 +274,12 @@ public class ProducerConfig extends AbstractConfig {
/** <code>retries</code> */
public static final String RETRIES_CONFIG = CommonClientConfigs.RETRIES_CONFIG;
- private static final String RETRIES_DOC = "Setting a value greater than zero will cause the client to resend any record whose send fails with a potentially transient error."
- + " Note that this retry is no different than if the client resent the record upon receiving the error."
- + " Produce requests will be failed before the number of retries has been exhausted if the timeout configured by"
- + " <code>" + DELIVERY_TIMEOUT_MS_CONFIG + "</code> expires first before successful acknowledgement. Users should generally"
- + " prefer to leave this config unset and instead use <code>" + DELIVERY_TIMEOUT_MS_CONFIG + "</code> to control"
+ private static final String RETRIES_DOC = "Number of times to retry a request that fails with a transient error."
+ + " Setting a value greater than zero will cause the client to resend any record whose send fails with a potentially transient error. "
+ + " Requests will be retried this many times until they succeed, fail with a non-transient error, or the <code> DELIVERY_TIMEOUT_MS_CONFIG </code> expires."
+ + " Note that this automatic retry is no different than if the client resent the record upon receiving the error."
Review Comment:
Same page on the meaning (I also take it as "the client resent the request" == "application code calls send(...)").
And totally agree with you that this is wrong from the idempotence point of view, my point was only that I read it as making a valid point about the automatic retries not doing any magic, just resend. I changed the sentence, let me know
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Improve docs for retries & cleanup [kafka]
Posted by "lianetm (via GitHub)" <gi...@apache.org>.
lianetm commented on code in PR #19595:
URL: https://github.com/apache/kafka/pull/19595#discussion_r2067065924
##########
clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java:
##########
@@ -276,6 +276,7 @@ public class ProducerConfig extends AbstractConfig {
public static final String RETRIES_CONFIG = CommonClientConfigs.RETRIES_CONFIG;
private static final String RETRIES_DOC = "Setting a value greater than zero will cause the client to resend any record whose send fails with a potentially transient error."
+ " Note that this retry is no different than if the client resent the record upon receiving the error."
+ + " Setting a value of zero will make that transient errors won't be retried, and will be propagated to the application to be handled."
Review Comment:
yeah, let's get there. The delivery timeout config has several applications really, but related to retry, the point is that it's a time boundary for retries. So its relevant when using retries > 0 I expect (technically it applies to both, but if we have retries=0 means no retry, so the time boundary for retries is pointless)
Makes sense? let me group the sentence better with this in mind.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Improve docs for retries & cleanup [kafka]
Posted by "lianetm (via GitHub)" <gi...@apache.org>.
lianetm commented on code in PR #19595:
URL: https://github.com/apache/kafka/pull/19595#discussion_r2070246819
##########
clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java:
##########
@@ -274,11 +274,12 @@ public class ProducerConfig extends AbstractConfig {
/** <code>retries</code> */
public static final String RETRIES_CONFIG = CommonClientConfigs.RETRIES_CONFIG;
- private static final String RETRIES_DOC = "Setting a value greater than zero will cause the client to resend any record whose send fails with a potentially transient error."
- + " Note that this retry is no different than if the client resent the record upon receiving the error."
- + " Produce requests will be failed before the number of retries has been exhausted if the timeout configured by"
- + " <code>" + DELIVERY_TIMEOUT_MS_CONFIG + "</code> expires first before successful acknowledgement. Users should generally"
- + " prefer to leave this config unset and instead use <code>" + DELIVERY_TIMEOUT_MS_CONFIG + "</code> to control"
+ private static final String RETRIES_DOC = "Number of times to retry a request that fails with a transient error."
+ + " Setting a value greater than zero will cause the client to resend any record whose send fails with a potentially transient error. "
+ + " Requests will be retried this many times until they succeed, fail with a non-transient error, or the <code> DELIVERY_TIMEOUT_MS_CONFIG </code> expires."
+ + " Note that this automatic retry is no different than if the client resent the record upon receiving the error."
+ + " Setting a value of zero will disable this automatic retry behaviour, so that the transient errors will be propagated to the application to be handled."
+ + " Users should generally prefer to leave this config unset and instead use <code>" + DELIVERY_TIMEOUT_MS_CONFIG + "</code> to control"
+ " retry behavior."
+ "<p>"
+ "Enabling idempotence requires this config value to be greater than 0."
Review Comment:
yeah, I agree with the feeling, but as it's often the case, it was a matter of a trade off, the reason explained here https://issues.apache.org/jira/browse/KAFKA-13673.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Improve docs for retries & cleanup [kafka]
Posted by "mjsax (via GitHub)" <gi...@apache.org>.
mjsax commented on code in PR #19595:
URL: https://github.com/apache/kafka/pull/19595#discussion_r2069128680
##########
clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java:
##########
@@ -274,11 +274,12 @@ public class ProducerConfig extends AbstractConfig {
/** <code>retries</code> */
public static final String RETRIES_CONFIG = CommonClientConfigs.RETRIES_CONFIG;
- private static final String RETRIES_DOC = "Setting a value greater than zero will cause the client to resend any record whose send fails with a potentially transient error."
- + " Note that this retry is no different than if the client resent the record upon receiving the error."
- + " Produce requests will be failed before the number of retries has been exhausted if the timeout configured by"
- + " <code>" + DELIVERY_TIMEOUT_MS_CONFIG + "</code> expires first before successful acknowledgement. Users should generally"
- + " prefer to leave this config unset and instead use <code>" + DELIVERY_TIMEOUT_MS_CONFIG + "</code> to control"
+ private static final String RETRIES_DOC = "Number of times to retry a request that fails with a transient error."
+ + " Setting a value greater than zero will cause the client to resend any record whose send fails with a potentially transient error. "
+ + " Requests will be retried this many times until they succeed, fail with a non-transient error, or the <code> DELIVERY_TIMEOUT_MS_CONFIG </code> expires."
+ + " Note that this automatic retry is no different than if the client resent the record upon receiving the error."
+ + " Setting a value of zero will disable this automatic retry behaviour, so that the transient errors will be propagated to the application to be handled."
+ + " Users should generally prefer to leave this config unset and instead use <code>" + DELIVERY_TIMEOUT_MS_CONFIG + "</code> to control"
+ " retry behavior."
+ "<p>"
+ "Enabling idempotence requires this config value to be greater than 0."
Review Comment:
> If retries=zero it won't fail, it simply disables idempotence automatically and the retries=0 is respected.
That is very unexpected to me -- I would expect a config error. What is the reason for this? Sound like a footgun to me, if changing `retries` has this side effect. (Side effect are IMHO in general most likely a bad thing.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Improve docs for retries & cleanup [kafka]
Posted by "lianetm (via GitHub)" <gi...@apache.org>.
lianetm commented on code in PR #19595:
URL: https://github.com/apache/kafka/pull/19595#discussion_r2068953392
##########
clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java:
##########
@@ -415,7 +415,7 @@ public KafkaProducer(Properties properties, Serializer<K> keySerializer, Seriali
this.transactionManager = configureTransactionState(config, logContext);
// There is no need to do work required for adaptive partitioning, if we use a custom partitioner.
boolean enableAdaptivePartitioning = partitionerPlugin.get() == null &&
- config.getBoolean(ProducerConfig.PARTITIONER_ADPATIVE_PARTITIONING_ENABLE_CONFIG);
Review Comment:
uh totally, removed all the changes on this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Improve docs for retries & cleanup [kafka]
Posted by "lianetm (via GitHub)" <gi...@apache.org>.
lianetm commented on PR #19595:
URL: https://github.com/apache/kafka/pull/19595#issuecomment-2842454144
Thank you all for the feedback! Comments addressed and answers inline.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Improve docs for retries & cleanup [kafka]
Posted by "lianetm (via GitHub)" <gi...@apache.org>.
lianetm commented on code in PR #19595:
URL: https://github.com/apache/kafka/pull/19595#discussion_r2068951006
##########
clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java:
##########
@@ -274,11 +274,12 @@ public class ProducerConfig extends AbstractConfig {
/** <code>retries</code> */
public static final String RETRIES_CONFIG = CommonClientConfigs.RETRIES_CONFIG;
- private static final String RETRIES_DOC = "Setting a value greater than zero will cause the client to resend any record whose send fails with a potentially transient error."
- + " Note that this retry is no different than if the client resent the record upon receiving the error."
- + " Produce requests will be failed before the number of retries has been exhausted if the timeout configured by"
- + " <code>" + DELIVERY_TIMEOUT_MS_CONFIG + "</code> expires first before successful acknowledgement. Users should generally"
- + " prefer to leave this config unset and instead use <code>" + DELIVERY_TIMEOUT_MS_CONFIG + "</code> to control"
+ private static final String RETRIES_DOC = "Number of times to retry a request that fails with a transient error."
+ + " Setting a value greater than zero will cause the client to resend any record whose send fails with a potentially transient error. "
+ + " Requests will be retried this many times until they succeed, fail with a non-transient error, or the <code> DELIVERY_TIMEOUT_MS_CONFIG </code> expires."
+ + " Note that this automatic retry is no different than if the client resent the record upon receiving the error."
+ + " Setting a value of zero will disable this automatic retry behaviour, so that the transient errors will be propagated to the application to be handled."
+ + " Users should generally prefer to leave this config unset and instead use <code>" + DELIVERY_TIMEOUT_MS_CONFIG + "</code> to control"
+ " retry behavior."
+ "<p>"
+ "Enabling idempotence requires this config value to be greater than 0."
Review Comment:
well the trick is that there is a diff between user enabling idemp explicitly (then it does "require this config value to be greater than 0."), vs. user not setting the prop, in which case idemp is enabled by default as you said, but it does not required the retries >0 (If retries=zero it won't fail, it simply disables idempotence automatically and the retries=0 is respected)
##########
clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java:
##########
@@ -274,11 +274,12 @@ public class ProducerConfig extends AbstractConfig {
/** <code>retries</code> */
public static final String RETRIES_CONFIG = CommonClientConfigs.RETRIES_CONFIG;
- private static final String RETRIES_DOC = "Setting a value greater than zero will cause the client to resend any record whose send fails with a potentially transient error."
- + " Note that this retry is no different than if the client resent the record upon receiving the error."
- + " Produce requests will be failed before the number of retries has been exhausted if the timeout configured by"
- + " <code>" + DELIVERY_TIMEOUT_MS_CONFIG + "</code> expires first before successful acknowledgement. Users should generally"
- + " prefer to leave this config unset and instead use <code>" + DELIVERY_TIMEOUT_MS_CONFIG + "</code> to control"
+ private static final String RETRIES_DOC = "Number of times to retry a request that fails with a transient error."
+ + " Setting a value greater than zero will cause the client to resend any record whose send fails with a potentially transient error. "
+ + " Requests will be retried this many times until they succeed, fail with a non-transient error, or the <code> DELIVERY_TIMEOUT_MS_CONFIG </code> expires."
+ + " Note that this automatic retry is no different than if the client resent the record upon receiving the error."
+ + " Setting a value of zero will disable this automatic retry behaviour, so that the transient errors will be propagated to the application to be handled."
+ + " Users should generally prefer to leave this config unset and instead use <code>" + DELIVERY_TIMEOUT_MS_CONFIG + "</code> to control"
+ " retry behavior."
+ "<p>"
+ "Enabling idempotence requires this config value to be greater than 0."
Review Comment:
well the trick is that there is a diff between user enabling idemp explicitly (then it does "require this config value to be greater than 0."), vs. user not setting the prop, in which case idemp is enabled by default as you said, but it does not required the retries >0 (If retries=zero it won't fail, it simply disables idempotence automatically and the retries=0 is respected). Makes sense?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Improve docs for retries & cleanup [kafka]
Posted by "lianetm (via GitHub)" <gi...@apache.org>.
lianetm commented on code in PR #19595:
URL: https://github.com/apache/kafka/pull/19595#discussion_r2068951006
##########
clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java:
##########
@@ -274,11 +274,12 @@ public class ProducerConfig extends AbstractConfig {
/** <code>retries</code> */
public static final String RETRIES_CONFIG = CommonClientConfigs.RETRIES_CONFIG;
- private static final String RETRIES_DOC = "Setting a value greater than zero will cause the client to resend any record whose send fails with a potentially transient error."
- + " Note that this retry is no different than if the client resent the record upon receiving the error."
- + " Produce requests will be failed before the number of retries has been exhausted if the timeout configured by"
- + " <code>" + DELIVERY_TIMEOUT_MS_CONFIG + "</code> expires first before successful acknowledgement. Users should generally"
- + " prefer to leave this config unset and instead use <code>" + DELIVERY_TIMEOUT_MS_CONFIG + "</code> to control"
+ private static final String RETRIES_DOC = "Number of times to retry a request that fails with a transient error."
+ + " Setting a value greater than zero will cause the client to resend any record whose send fails with a potentially transient error. "
+ + " Requests will be retried this many times until they succeed, fail with a non-transient error, or the <code> DELIVERY_TIMEOUT_MS_CONFIG </code> expires."
+ + " Note that this automatic retry is no different than if the client resent the record upon receiving the error."
+ + " Setting a value of zero will disable this automatic retry behaviour, so that the transient errors will be propagated to the application to be handled."
+ + " Users should generally prefer to leave this config unset and instead use <code>" + DELIVERY_TIMEOUT_MS_CONFIG + "</code> to control"
+ " retry behavior."
+ "<p>"
+ "Enabling idempotence requires this config value to be greater than 0."
Review Comment:
well the trick is that there is a diff between user enabling idemp explicitly (then it does "require this config value to be greater than 0.", will throw otherwise), vs. user not setting the prop, in which case idemp is enabled by default as you said, but it does not required the retries >0 (If retries=zero it won't fail, it simply disables idempotence automatically and the retries=0 is respected). Makes sense?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Improve docs for retries & cleanup [kafka]
Posted by "lianetm (via GitHub)" <gi...@apache.org>.
lianetm commented on code in PR #19595:
URL: https://github.com/apache/kafka/pull/19595#discussion_r2068968793
##########
clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java:
##########
@@ -274,11 +274,12 @@ public class ProducerConfig extends AbstractConfig {
/** <code>retries</code> */
public static final String RETRIES_CONFIG = CommonClientConfigs.RETRIES_CONFIG;
- private static final String RETRIES_DOC = "Setting a value greater than zero will cause the client to resend any record whose send fails with a potentially transient error."
- + " Note that this retry is no different than if the client resent the record upon receiving the error."
- + " Produce requests will be failed before the number of retries has been exhausted if the timeout configured by"
- + " <code>" + DELIVERY_TIMEOUT_MS_CONFIG + "</code> expires first before successful acknowledgement. Users should generally"
- + " prefer to leave this config unset and instead use <code>" + DELIVERY_TIMEOUT_MS_CONFIG + "</code> to control"
+ private static final String RETRIES_DOC = "Number of times to retry a request that fails with a transient error."
+ + " Setting a value greater than zero will cause the client to resend any record whose send fails with a potentially transient error. "
+ + " Requests will be retried this many times until they succeed, fail with a non-transient error, or the <code> DELIVERY_TIMEOUT_MS_CONFIG </code> expires."
+ + " Note that this automatic retry is no different than if the client resent the record upon receiving the error."
Review Comment:
well I would say it's correct saying that automatic retries won't mess around/change the request (and that would be exactly the same as if the client resent the request, without messing around with it). Assuming no one changes the request (us internally, or the client app), both retries on retriables would behave the same right? Makes sense?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Improve docs for retries & cleanup [kafka]
Posted by "lianetm (via GitHub)" <gi...@apache.org>.
lianetm commented on code in PR #19595:
URL: https://github.com/apache/kafka/pull/19595#discussion_r2068953392
##########
clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java:
##########
@@ -415,7 +415,7 @@ public KafkaProducer(Properties properties, Serializer<K> keySerializer, Seriali
this.transactionManager = configureTransactionState(config, logContext);
// There is no need to do work required for adaptive partitioning, if we use a custom partitioner.
boolean enableAdaptivePartitioning = partitionerPlugin.get() == null &&
- config.getBoolean(ProducerConfig.PARTITIONER_ADPATIVE_PARTITIONING_ENABLE_CONFIG);
Review Comment:
uh totally, good catch. Removed all the changes on this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Improve docs for retries & cleanup [kafka]
Posted by "mjsax (via GitHub)" <gi...@apache.org>.
mjsax commented on code in PR #19595:
URL: https://github.com/apache/kafka/pull/19595#discussion_r2067041079
##########
clients/src/main/java/org/apache/kafka/clients/CommonClientConfigs.java:
##########
@@ -88,8 +88,9 @@ public class CommonClientConfigs {
"If provided, the backoff per host will increase exponentially for each consecutive connection failure, up to this maximum. After calculating the backoff increase, 20% random jitter is added to avoid connection storms.";
public static final String RETRIES_CONFIG = "retries";
- public static final String RETRIES_DOC = "Setting a value greater than zero will cause the client to resend any request that fails with a potentially transient error." +
- " It is recommended to set the value to either zero or `MAX_VALUE` and use corresponding timeout parameters to control how long a client should retry a request.";
+ public static final String RETRIES_DOC = "It is recommended to set the value to either `MAX_VALUE` or zero, and use corresponding timeout parameters to control how long a client should retry a request." +
Review Comment:
I think we should recommend to keep the default of `MAX_VALUE`?
And say, another "reasonable" config is zero for the at-most-once case?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Improve docs for retries & cleanup [kafka]
Posted by "lianetm (via GitHub)" <gi...@apache.org>.
lianetm commented on code in PR #19595:
URL: https://github.com/apache/kafka/pull/19595#discussion_r2067080515
##########
clients/src/main/java/org/apache/kafka/clients/CommonClientConfigs.java:
##########
@@ -88,8 +88,9 @@ public class CommonClientConfigs {
"If provided, the backoff per host will increase exponentially for each consecutive connection failure, up to this maximum. After calculating the backoff increase, 20% random jitter is added to avoid connection storms.";
public static final String RETRIES_CONFIG = "retries";
- public static final String RETRIES_DOC = "Setting a value greater than zero will cause the client to resend any request that fails with a potentially transient error." +
- " It is recommended to set the value to either zero or `MAX_VALUE` and use corresponding timeout parameters to control how long a client should retry a request.";
+ public static final String RETRIES_DOC = "It is recommended to set the value to either `MAX_VALUE` or zero, and use corresponding timeout parameters to control how long a client should retry a request." +
Review Comment:
Exactly, MAX_VALUE is actually the default. That's why I intentionally flipped the order here (that's was actually part of the confusion, that the "it's recommended..." starting mentioning Zero).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Improve docs for retries & cleanup [kafka]
Posted by "mjsax (via GitHub)" <gi...@apache.org>.
mjsax commented on code in PR #19595:
URL: https://github.com/apache/kafka/pull/19595#discussion_r2067567268
##########
clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java:
##########
@@ -274,11 +274,12 @@ public class ProducerConfig extends AbstractConfig {
/** <code>retries</code> */
public static final String RETRIES_CONFIG = CommonClientConfigs.RETRIES_CONFIG;
- private static final String RETRIES_DOC = "Setting a value greater than zero will cause the client to resend any record whose send fails with a potentially transient error."
- + " Note that this retry is no different than if the client resent the record upon receiving the error."
- + " Produce requests will be failed before the number of retries has been exhausted if the timeout configured by"
- + " <code>" + DELIVERY_TIMEOUT_MS_CONFIG + "</code> expires first before successful acknowledgement. Users should generally"
- + " prefer to leave this config unset and instead use <code>" + DELIVERY_TIMEOUT_MS_CONFIG + "</code> to control"
+ private static final String RETRIES_DOC = "Number of times to retry a request that fails with a transient error."
+ + " Setting a value greater than zero will cause the client to resend any record whose send fails with a potentially transient error. "
+ + " Requests will be retried this many times until they succeed, fail with a non-transient error, or the <code> DELIVERY_TIMEOUT_MS_CONFIG </code> expires."
Review Comment:
```suggestion
+ " Requests will be retried this many times until they succeed, fail with a non-transient error, or the <code>DELIVERY_TIMEOUT_MS_CONFIG</code> expires."
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Improve docs for retries & cleanup [kafka]
Posted by "mjsax (via GitHub)" <gi...@apache.org>.
mjsax commented on code in PR #19595:
URL: https://github.com/apache/kafka/pull/19595#discussion_r2067568767
##########
clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java:
##########
@@ -274,11 +274,12 @@ public class ProducerConfig extends AbstractConfig {
/** <code>retries</code> */
public static final String RETRIES_CONFIG = CommonClientConfigs.RETRIES_CONFIG;
- private static final String RETRIES_DOC = "Setting a value greater than zero will cause the client to resend any record whose send fails with a potentially transient error."
- + " Note that this retry is no different than if the client resent the record upon receiving the error."
- + " Produce requests will be failed before the number of retries has been exhausted if the timeout configured by"
- + " <code>" + DELIVERY_TIMEOUT_MS_CONFIG + "</code> expires first before successful acknowledgement. Users should generally"
- + " prefer to leave this config unset and instead use <code>" + DELIVERY_TIMEOUT_MS_CONFIG + "</code> to control"
+ private static final String RETRIES_DOC = "Number of times to retry a request that fails with a transient error."
+ + " Setting a value greater than zero will cause the client to resend any record whose send fails with a potentially transient error. "
+ + " Requests will be retried this many times until they succeed, fail with a non-transient error, or the <code> DELIVERY_TIMEOUT_MS_CONFIG </code> expires."
Review Comment:
Well, should this actually be `<code>" + DELIVERY_TIMEOUT_MS_CONFIG + "</code>` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Improve docs for retries & cleanup [kafka]
Posted by "Yunyung (via GitHub)" <gi...@apache.org>.
Yunyung commented on PR #19595:
URL: https://github.com/apache/kafka/pull/19595#issuecomment-2840596590
Thanks for the PR. I left just one minor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Improve docs for retries & cleanup [kafka]
Posted by "lianetm (via GitHub)" <gi...@apache.org>.
lianetm commented on code in PR #19595:
URL: https://github.com/apache/kafka/pull/19595#discussion_r2067085137
##########
clients/src/main/java/org/apache/kafka/clients/CommonClientConfigs.java:
##########
@@ -88,8 +88,9 @@ public class CommonClientConfigs {
"If provided, the backoff per host will increase exponentially for each consecutive connection failure, up to this maximum. After calculating the backoff increase, 20% random jitter is added to avoid connection storms.";
public static final String RETRIES_CONFIG = "retries";
- public static final String RETRIES_DOC = "Setting a value greater than zero will cause the client to resend any request that fails with a potentially transient error." +
- " It is recommended to set the value to either zero or `MAX_VALUE` and use corresponding timeout parameters to control how long a client should retry a request.";
+ public static final String RETRIES_DOC = "It is recommended to set the value to either `MAX_VALUE` or zero, and use corresponding timeout parameters to control how long a client should retry a request." +
Review Comment:
didn't go as far as saying "recommended is max." (full stop), since here it's the commons one that truly doesn't define the default even, so I guess it could depend on the usage (in practice it's admin and producer, and they do effectively max it out by default)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Improve docs for retries & cleanup [kafka]
Posted by "mjsax (via GitHub)" <gi...@apache.org>.
mjsax commented on code in PR #19595:
URL: https://github.com/apache/kafka/pull/19595#discussion_r2067569227
##########
clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java:
##########
@@ -274,11 +274,12 @@ public class ProducerConfig extends AbstractConfig {
/** <code>retries</code> */
public static final String RETRIES_CONFIG = CommonClientConfigs.RETRIES_CONFIG;
- private static final String RETRIES_DOC = "Setting a value greater than zero will cause the client to resend any record whose send fails with a potentially transient error."
- + " Note that this retry is no different than if the client resent the record upon receiving the error."
- + " Produce requests will be failed before the number of retries has been exhausted if the timeout configured by"
- + " <code>" + DELIVERY_TIMEOUT_MS_CONFIG + "</code> expires first before successful acknowledgement. Users should generally"
- + " prefer to leave this config unset and instead use <code>" + DELIVERY_TIMEOUT_MS_CONFIG + "</code> to control"
+ private static final String RETRIES_DOC = "Number of times to retry a request that fails with a transient error."
+ + " Setting a value greater than zero will cause the client to resend any record whose send fails with a potentially transient error. "
+ + " Requests will be retried this many times until they succeed, fail with a non-transient error, or the <code> DELIVERY_TIMEOUT_MS_CONFIG </code> expires."
+ + " Note that this automatic retry is no different than if the client resent the record upon receiving the error."
+ + " Setting a value of zero will disable this automatic retry behaviour, so that the transient errors will be propagated to the application to be handled."
+ + " Users should generally prefer to leave this config unset and instead use <code>" + DELIVERY_TIMEOUT_MS_CONFIG + "</code> to control"
+ " retry behavior."
+ "<p>"
+ "Enabling idempotence requires this config value to be greater than 0."
Review Comment:
Given that idempotent producer is enabled by default, might be worth to rephrase this, too?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Improve docs for retries & cleanup [kafka]
Posted by "mjsax (via GitHub)" <gi...@apache.org>.
mjsax commented on code in PR #19595:
URL: https://github.com/apache/kafka/pull/19595#discussion_r2067568336
##########
clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java:
##########
@@ -274,11 +274,12 @@ public class ProducerConfig extends AbstractConfig {
/** <code>retries</code> */
public static final String RETRIES_CONFIG = CommonClientConfigs.RETRIES_CONFIG;
- private static final String RETRIES_DOC = "Setting a value greater than zero will cause the client to resend any record whose send fails with a potentially transient error."
- + " Note that this retry is no different than if the client resent the record upon receiving the error."
- + " Produce requests will be failed before the number of retries has been exhausted if the timeout configured by"
- + " <code>" + DELIVERY_TIMEOUT_MS_CONFIG + "</code> expires first before successful acknowledgement. Users should generally"
- + " prefer to leave this config unset and instead use <code>" + DELIVERY_TIMEOUT_MS_CONFIG + "</code> to control"
+ private static final String RETRIES_DOC = "Number of times to retry a request that fails with a transient error."
+ + " Setting a value greater than zero will cause the client to resend any record whose send fails with a potentially transient error. "
+ + " Requests will be retried this many times until they succeed, fail with a non-transient error, or the <code> DELIVERY_TIMEOUT_MS_CONFIG </code> expires."
+ + " Note that this automatic retry is no different than if the client resent the record upon receiving the error."
Review Comment:
Is this actually correct? I mean, internal retires are idempotent (at least by default, as long as idempotency is not disabled), while application retires are not idempotent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Improve docs for retries & cleanup [kafka]
Posted by "Yunyung (via GitHub)" <gi...@apache.org>.
Yunyung commented on code in PR #19595:
URL: https://github.com/apache/kafka/pull/19595#discussion_r2067714092
##########
clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java:
##########
@@ -100,7 +100,7 @@ public class ProducerConfig extends AbstractConfig {
+ "similar or lower producer latency despite the increased linger.";
/** <code>partitioner.adaptive.partitioning.enable</code> */
- public static final String PARTITIONER_ADPATIVE_PARTITIONING_ENABLE_CONFIG = "partitioner.adaptive.partitioning.enable";
+ public static final String PARTITIONER_ADAPTIVE_PARTITIONING_ENABLE_CONFIG = "partitioner.adaptive.partitioning.enable";
private static final String PARTITIONER_ADPATIVE_PARTITIONING_ENABLE_DOC =
Review Comment:
Also typo.
```suggestion
private static final String PARTITIONER_ADAPTIVE_PARTITIONING_ENABLE_DOC =
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Improve docs for retries & cleanup [kafka]
Posted by "lianetm (via GitHub)" <gi...@apache.org>.
lianetm merged PR #19595:
URL: https://github.com/apache/kafka/pull/19595
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org