You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/01/22 14:22:51 UTC
[GitHub] [flink] tillrohrmann commented on a change in pull request #10921:
[FLINK-15692][state backend] Enable limiting RocksDB memory consumption by
default
tillrohrmann commented on a change in pull request #10921: [FLINK-15692][state backend] Enable limiting RocksDB memory consumption by default
URL: https://github.com/apache/flink/pull/10921#discussion_r369570350
##########
File path: flink-runtime/src/test/java/org/apache/flink/runtime/operators/testutils/MockEnvironmentBuilder.java
##########
@@ -125,6 +129,13 @@ public MockEnvironmentBuilder setMetricGroup(TaskMetricGroup taskMetricGroup) {
return this;
}
+ public MockEnvironmentBuilder setIOManager(IOManager ioManager) {
+ // close previous io-manager.
+ IOUtils.closeQuietly(this.ioManager);
Review comment:
Instead of pre-initializing `ioManager` with `new IOManagerAsync()` we could leave the field `null`. In the build method we could create an `IOManagerAsync` if no other manager has been set.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services