You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/08/17 02:43:25 UTC

[GitHub] [arrow-rs] liukun4515 commented on a diff in pull request #2471: Remove unnecessary Option from Int96

liukun4515 commented on code in PR #2471:
URL: https://github.com/apache/arrow-rs/pull/2471#discussion_r947399218


##########
parquet/src/data_type.rs:
##########
@@ -36,29 +36,27 @@ use crate::util::{
 
 /// Rust representation for logical type INT96, value is backed by an array of `u32`.
 /// The type only takes 12 bytes, without extra padding.
-#[derive(Clone, Debug, PartialOrd, Default)]
+#[derive(Clone, Debug, PartialOrd, Default, PartialEq, Eq)]

Review Comment:
   Not a question about this issue.
   How to compare the INT96 in parquet? How to ensure the order of two INT64?
   From the parquet spec https://github.com/apache/parquet-format/blob/54e53e5d7794d383529dd30746378f19a12afd58/src/main/thrift/parquet.thrift#L36, the type of INT96 has be deprecated.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org