You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hbase.apache.org by "wenfeiyi666 (Jira)" <ji...@apache.org> on 2020/09/11 08:51:00 UTC

[jira] [Updated] (HBASE-24792) LogRoller.walRollFinished fix

     [ https://issues.apache.org/jira/browse/HBASE-24792?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

wenfeiyi666 updated HBASE-24792:
--------------------------------
    Description: 
The LogRoller.walRollFinished impl is already buggy. This just checks the status of the boolean. Once we start a roll on a WAL, we reset the boolean (Even before patch HBASE-24665). So it is not clearly telling anything abt the roll status. This can return true even while an active wal roll is going on.

We might need another boolean in Controller which clearly tracks whether we are ongoing a roll.

> LogRoller.walRollFinished fix
> -----------------------------
>
>                 Key: HBASE-24792
>                 URL: https://issues.apache.org/jira/browse/HBASE-24792
>             Project: HBase
>          Issue Type: Improvement
>    Affects Versions: 3.0.0-alpha-1, 2.3.1, 2.2.6
>            Reporter: wenfeiyi666
>            Assignee: wenfeiyi666
>            Priority: Minor
>             Fix For: 3.0.0-alpha-1, 2.2.7, 2.3.2
>
>
> The LogRoller.walRollFinished impl is already buggy. This just checks the status of the boolean. Once we start a roll on a WAL, we reset the boolean (Even before patch HBASE-24665). So it is not clearly telling anything abt the roll status. This can return true even while an active wal roll is going on.
> We might need another boolean in Controller which clearly tracks whether we are ongoing a roll.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)