You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tika.apache.org by gr...@apache.org on 2016/10/31 17:24:51 UTC

tika git commit: TIKA-2056 Make ExternalParser.LineConsumer Serializable

Repository: tika
Updated Branches:
  refs/heads/master e215b9d7f -> b67373f22


TIKA-2056 Make ExternalParser.LineConsumer Serializable

Anonymous implementation of null LineConsumer in ExternalParser was
non-serializable which broke `ForkParser` if any external parsers were
available in system (like `ffmpeg` or `exiftool`).

Fixes #TIKA-2056


Project: http://git-wip-us.apache.org/repos/asf/tika/repo
Commit: http://git-wip-us.apache.org/repos/asf/tika/commit/b67373f2
Tree: http://git-wip-us.apache.org/repos/asf/tika/tree/b67373f2
Diff: http://git-wip-us.apache.org/repos/asf/tika/diff/b67373f2

Branch: refs/heads/master
Commit: b67373f22bb84d9e40019836817784faaff61ec8
Parents: e215b9d
Author: Konstantin Gribov <gr...@gmail.com>
Authored: Mon Oct 31 20:09:23 2016 +0300
Committer: Konstantin Gribov <gr...@gmail.com>
Committed: Mon Oct 31 20:18:59 2016 +0300

----------------------------------------------------------------------
 .../java/org/apache/tika/parser/external/ExternalParser.java     | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/tika/blob/b67373f2/tika-core/src/main/java/org/apache/tika/parser/external/ExternalParser.java
----------------------------------------------------------------------
diff --git a/tika-core/src/main/java/org/apache/tika/parser/external/ExternalParser.java b/tika-core/src/main/java/org/apache/tika/parser/external/ExternalParser.java
index 0ec8eb6..3a10f6a 100644
--- a/tika-core/src/main/java/org/apache/tika/parser/external/ExternalParser.java
+++ b/tika-core/src/main/java/org/apache/tika/parser/external/ExternalParser.java
@@ -56,7 +56,7 @@ public class ExternalParser extends AbstractParser {
      * Consumer contract
      * @since Apache Tika 1.14
      */
-    public interface LineConsumer {
+    public interface LineConsumer extends Serializable {
         /**
          * Consume a line
          * @param line a line of string
@@ -69,7 +69,7 @@ public class ExternalParser extends AbstractParser {
         LineConsumer NULL = new LineConsumer() {
             @Override
             public void consume(String line) {
-               //ignore
+                // ignores
             }
         };
     }