[GitHub] [incubator-sedona] netanel246 commented on a change in pull request #484: [SEDONA-1] Make Sedona depend on a LocationTech JTS 1.16.1 fork

[GitBox <gi...@apache.org>]

netanel246 commented on a change in pull request #484:
URL: https://github.com/apache/incubator-sedona/pull/484#discussion_r499519523



##########
File path: core/pom.xml
##########
@@ -32,10 +32,16 @@
 	<packaging>jar</packaging>
 
     <dependencies>
+        <dependency>
+            <groupId>org.locationtech.jts</groupId>
+            <artifactId>jts-core</artifactId>
+            <version>1.16.2-SNAPSHOT</version>

Review comment:
       There is a special reason why you're using the SNAPSHOT version?
   Why we can't use deployable version 1.16.1?

##########
File path: core/pom.xml
##########
@@ -35,7 +35,7 @@
         <dependency>
             <groupId>org.wololo</groupId>
             <artifactId>jts2geojson</artifactId>
-            <version>0.10.0</version>
+            <version>0.13.0</version>

Review comment:
       Why not using [0.14.3](https://github.com/bjornharrtell/jts2geojson/blob/0.14.3/pom.xml) (newest version)?. 
   It's also compatible with JTS version 1.16.1




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org