You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "skytin1004 (via GitHub)" <gi...@apache.org> on 2023/05/14 07:58:33 UTC
[GitHub] [iceberg] skytin1004 opened a new pull request, #7609: Core: Migration to JUnit5 in avro
skytin1004 opened a new pull request, #7609:
URL: https://github.com/apache/iceberg/pull/7609
This pull request is related to the issue "Move JUnit4 tests to JUnit5 https://github.com/apache/iceberg/issues/7160".
"AvroDataTest","TestAvroDataWriter","TestAvroDeleteWriters","TestAvroEnums","TestAvroFileSplit"
I migrated these five test files from JUnit4 to JUnit5, and they all passed test.
<img width="1223" alt="AvorDataTest_passed" src="https://github.com/apache/iceberg/assets/99078115/9b37e312-3373-43cd-a186-bc85fb15ff59">
<img width="1111" alt="TestAzroDataWriter_passed" src="https://github.com/apache/iceberg/assets/99078115/134a5be3-c25c-4a78-9c0f-d8e8070154a4">
<img width="1118" alt="TestAvroDeleteWriters_passed" src="https://github.com/apache/iceberg/assets/99078115/bdd19d90-81dd-4702-b075-83f6182f6e01">
<img width="1174" alt="TestAvroEnums_passed" src="https://github.com/apache/iceberg/assets/99078115/ccc6abfe-c310-4d42-9a11-898aa0f621ff">
<img width="1174" alt="TestAvroFileSplit_passed" src="https://github.com/apache/iceberg/assets/99078115/555c3ab9-4e4e-47ea-b8b1-7b9712b004db">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] skytin1004 commented on a diff in pull request #7609: Core: Migration to JUnit5 in avro
Posted by "skytin1004 (via GitHub)" <gi...@apache.org>.
skytin1004 commented on code in PR #7609:
URL: https://github.com/apache/iceberg/pull/7609#discussion_r1193484413
##########
core/src/test/java/org/apache/iceberg/avro/AvroTestHelpers.java:
##########
@@ -82,7 +82,7 @@ static void assertEquals(Types.StructType struct, Record expected, Record actual
static void assertEquals(Types.ListType list, List<?> expected, List<?> actual) {
Type elementType = list.elementType();
- Assert.assertEquals("List size should match", expected.size(), actual.size());
+ org.junit.jupiter.api.Assertions.assertEquals(expected.size(), actual.size(),"List size should match");
Review Comment:
Thank you. I will revise it again based on your review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] skytin1004 closed pull request #7609: Core: Migration to JUnit5 in avro
Posted by "skytin1004 (via GitHub)" <gi...@apache.org>.
skytin1004 closed pull request #7609: Core: Migration to JUnit5 in avro
URL: https://github.com/apache/iceberg/pull/7609
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] nastra commented on a diff in pull request #7609: Core: Migration to JUnit5 in avro
Posted by "nastra (via GitHub)" <gi...@apache.org>.
nastra commented on code in PR #7609:
URL: https://github.com/apache/iceberg/pull/7609#discussion_r1193451485
##########
core/src/test/java/org/apache/iceberg/avro/AvroTestHelpers.java:
##########
@@ -82,7 +82,7 @@ static void assertEquals(Types.StructType struct, Record expected, Record actual
static void assertEquals(Types.ListType list, List<?> expected, List<?> actual) {
Type elementType = list.elementType();
- Assert.assertEquals("List size should match", expected.size(), actual.size());
+ org.junit.jupiter.api.Assertions.assertEquals(expected.size(), actual.size(),"List size should match");
Review Comment:
Based on the conversations in https://github.com/apache/iceberg/issues/7160 I think we'd rather want to use AssertJ assertions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] skytin1004 closed pull request #7609: Core: Migration to JUnit5 in avro
Posted by "skytin1004 (via GitHub)" <gi...@apache.org>.
skytin1004 closed pull request #7609: Core: Migration to JUnit5 in avro
URL: https://github.com/apache/iceberg/pull/7609
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org