You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by kf...@collab.net on 2004/08/18 14:54:13 UTC
Re: svn commit: r10676 - in trunk/subversion: libsvn_wc tests/clients/cmdline
philip@tigris.org writes:
> --- trunk/subversion/libsvn_wc/questions.c (original)
> +++ trunk/subversion/libsvn_wc/questions.c Tue Aug 17 18:47:06 2004
> @@ -341,7 +341,7 @@
> apr_md5_final (digest, &context);
>
> checksum = svn_md5_digest_to_cstring (digest, pool);
> - if (strcmp (checksum, entry->checksum) != 0)
> + if (entry->checksum && strcmp (checksum, entry->checksum) != 0)
> {
> return svn_error_createf
> (SVN_ERR_WC_CORRUPT_TEXT_BASE, NULL,
A thought: If entry->checksum is NULL, then all the checksumming work
done previous to this would turn out to have been a waste. Any reason
not to add conditionals so we don't init, update, nor finalize the
context if entry->checksum is NULL?
-Karl
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn commit: r10676 - in trunk/subversion: libsvn_wc
tests/clients/cmdline
Posted by Philip Martin <ph...@codematters.co.uk>.
kfogel@collab.net writes:
> philip@tigris.org writes:
>> --- trunk/subversion/libsvn_wc/questions.c (original)
>> +++ trunk/subversion/libsvn_wc/questions.c Tue Aug 17 18:47:06 2004
>> @@ -341,7 +341,7 @@
>> apr_md5_final (digest, &context);
>>
>> checksum = svn_md5_digest_to_cstring (digest, pool);
>> - if (strcmp (checksum, entry->checksum) != 0)
>> + if (entry->checksum && strcmp (checksum, entry->checksum) != 0)
>> {
>> return svn_error_createf
>> (SVN_ERR_WC_CORRUPT_TEXT_BASE, NULL,
>
> A thought: If entry->checksum is NULL, then all the checksumming work
> done previous to this would turn out to have been a waste. Any reason
> not to add conditionals so we don't init, update, nor finalize the
> context if entry->checksum is NULL?
I considered it, but I don't know if the circumstances that cause it
to occur (copy then propset) happen often enough to warrent it.
--
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org