You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@struts.apache.org by GitBox <gi...@apache.org> on 2022/03/21 03:19:02 UTC

[GitHub] [struts] JCgH4164838Gh792C124B5 commented on a change in pull request #528: Potential expression cache enhancement for 2.6 series

JCgH4164838Gh792C124B5 commented on a change in pull request #528:
URL: https://github.com/apache/struts/pull/528#discussion_r830729848



##########
File path: core/src/main/java/com/opensymphony/xwork2/ognl/OgnlUtil.java
##########
@@ -78,14 +78,45 @@
     private boolean allowStaticMethodAccess;
     private boolean disallowProxyMemberAccess;
 
+    /**
+     * Construct a new OgnlUtil instance for use with the framework
+     */
     public OgnlUtil() {
+        this(null, null);  // Instantiate default Expression and BeanInfo caches (null factories)
+    }

Review comment:
       It is used in some of the unit test code.  Since it is a pre-existing public constructor, marking it as `deprecated` seems like the safer option.  The latest commit to the PR does that.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@struts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org