You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by GitBox <gi...@apache.org> on 2020/08/10 23:17:36 UTC

[GitHub] [avro] msamirkhan opened a new pull request #942: AVRO-2908: Skip enum using in.readEnum instead of in.readInt

msamirkhan opened a new pull request #942:
URL: https://github.com/apache/avro/pull/942


   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [ ] My PR addresses the following [Avro Jira](https://issues.apache.org/jira/browse/AVRO/) issues and references them in the PR title. For example, "AVRO-1234: My Avro PR"
     - https://issues.apache.org/jira/browse/AVRO-2908
     - In case you are adding a dependency, check if the license complies with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   
   ### Tests
   
   - [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
     - TestSkipEnumSchema
   
   ### Commits
   
   - [ ] My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](https://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [ ] In case of new functionality, my PR adds documentation that describes how to use it.
     - All the public functions and the classes in the PR contain Javadoc that explain what it does
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [avro] RyanSkraba commented on pull request #942: AVRO-2908: Skip enum using in.readEnum instead of in.readInt

Posted by GitBox <gi...@apache.org>.
RyanSkraba commented on pull request #942:
URL: https://github.com/apache/avro/pull/942#issuecomment-672804928


   Hey, a trivial fix I'd like to see (with my apologies -- I should have seen it with the patch!)  Would it be possible to move the test to the `org.apache.avro.generic` package instead of the core package?  It seems like this would be a better place for someone looking for this test, or to complete the missing unit tests on `skip`!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [avro] RyanSkraba merged pull request #942: AVRO-2908: Skip enum using in.readEnum instead of in.readInt

Posted by GitBox <gi...@apache.org>.
RyanSkraba merged pull request #942:
URL: https://github.com/apache/avro/pull/942


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [avro] msamirkhan commented on pull request #942: AVRO-2908: Skip enum using in.readEnum instead of in.readInt

Posted by GitBox <gi...@apache.org>.
msamirkhan commented on pull request #942:
URL: https://github.com/apache/avro/pull/942#issuecomment-673308759


   > Hey, a trivial fix I'd like to see (with my apologies -- I should have seen it with the patch!) Would it be possible to move the test to the `org.apache.avro.generic` package instead of the core package? It seems like this would be a better place for someone looking for this test, or to complete the missing unit tests on `skip`!
   
   Moved the test to `org.apache.avro.generic`. I kept the name though.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [avro] RyanSkraba commented on pull request #942: AVRO-2908: Skip enum using in.readEnum instead of in.readInt

Posted by GitBox <gi...@apache.org>.
RyanSkraba commented on pull request #942:
URL: https://github.com/apache/avro/pull/942#issuecomment-673371021


   Thanks for the fix!  I cherry-picked manually into [branch-1.10](https://github.com/apache/avro/commit/59a9401d7aa00f2d7442cd930cf5c0b545e1eb5d) so this fix will appear in the next 1.10 release as well.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org