You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "villebro (via GitHub)" <gi...@apache.org> on 2026/05/23 00:22:55 UTC

[PR] fix(api,controller,docs): validation, createdb SQL, migrate retry [superset-kubernetes-operator]

villebro opened a new pull request, #74:
URL: https://github.com/apache/superset-kubernetes-operator/pull/74

   ## Summary
   
   Addresses an 8-point external code review and fixes two bugs surfaced while testing the changes on a live cluster.
   
   ## Details
   
   ### Review findings
   
   1. **Probes follow custom container ports.** `buildDeploymentSpec` retargets default probes to the first user-overridden container port so the Service `targetPort` and the probe target stay in sync.
   2. **MySQL clone honors `excludeTableData`.** `buildMySQLCloneScript` emits a two-pass `mysqldump` (schema-only first pass for `excludeTableData`, data pass with `--ignore-table` for both lists) joined into a single stream.
   3. **CEL: `serviceAccount.name` required when `create: false`.** Prevents workloads from silently falling back to the namespace's default ServiceAccount.
   4. **CEL: `service.nodePort` min/max + type gating.** Rejects out-of-range nodePorts and rejects nodePort with `type: ClusterIP` at admission rather than at Service-create time.
   5. **Docs: PYTHONPATH.** The operator does not inject `PYTHONPATH`; it relies on the upstream image's default. Env-vars table corrected.
   6. **Docs: NetworkPolicy same-instance ports.** The generated same-instance ingress rule has no `Ports` restriction; the per-component table now matches the code.
   7. **API comments: Celery + Valkey.** "Requires Valkey" softened — Celery can be configured manually via `spec.config` without `spec.valkey`.
   8. **CEL: `websocketServer` requires image override.** The default Superset image does not contain `websocket_server.js`, so `websocketServer: {}` is now rejected at admission instead of producing a crashlooping Pod.
   
   ### Bugs found while testing
   
   - **Postgres `createdb` init container syntax error.** The script used psql's `:'name'` interpolation via `-c`, but psql's `-c` does not process client-side features — the literal `:'name'` reached the server, which rejected it as a syntax error. Replaced with shell-side single-quote doubling and direct interpolation into the SQL string.
   - **Migrate checksum missed the init-container script body.** The script is rendered by the operator binary, not the user's spec, so an operator upgrade that fixed the bug above did not change the migrate checksum, and a previously failed migrate stayed terminal-failed across operator restarts. `migrateInputs` now embeds the rendered Postgres/MySQL init script so operator-side fixes propagate into the checksum.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix(api,controller,docs): validation, createdb SQL, migrate retry [superset-kubernetes-operator]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #74:
URL: https://github.com/apache/superset-kubernetes-operator/pull/74#issuecomment-4523514347

   ## [Codecov](https://app.codecov.io/gh/apache/superset-kubernetes-operator/pull/74?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 82.00%. Comparing base ([`be26f9c`](https://app.codecov.io/gh/apache/superset-kubernetes-operator/commit/be26f9c156f2f7bc927c39d545dc63042faa935b?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`c17eab4`](https://app.codecov.io/gh/apache/superset-kubernetes-operator/commit/c17eab491c75c9b38ea32bbdb3f9e85c6dda8616?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   
   [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/superset-kubernetes-operator/pull/74?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).   
   :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix(api,controller,docs): validation, createdb SQL, migrate retry [superset-kubernetes-operator]

Posted by "villebro (via GitHub)" <gi...@apache.org>.
villebro merged PR #74:
URL: https://github.com/apache/superset-kubernetes-operator/pull/74


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org