You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Joe McDonnell (Code Review)" <ge...@cloudera.org> on 2019/11/20 22:26:54 UTC
[Impala-ASF-CR] IMPALA-9165: Hack to remove MasterProcWALs directory in kill-hbase.sh
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14757
Change subject: IMPALA-9165: Hack to remove MasterProcWALs directory in kill-hbase.sh
......................................................................
IMPALA-9165: Hack to remove MasterProcWALs directory in kill-hbase.sh
Some jobs have been hanging in the testdata/bin/create-hbase.sh
script. Logs during the hang show the HBase Master is stuck
unitialized:
Master startup cannot progress, in holding-pattern until region onlined.
...
ERROR master.HMaster: Master failed to complete initialization after 900000ms.
Anecdotally, the HBase Master doesn't have this problem if we remove
the /hbase/MasterProcWALs directory in kill-hbase.sh. This patch
does exactly that. It is a hack, and we should update this code
once we know what is going on.
Testing:
- test-with-docker.py fails without this patch and passes with it
- Hand testing on my minicluster shows that this allows HBase to
restart and be consistently usable
Change-Id: Icef3d30e6b539a175e03f63fcdbfb2d4608c08fa
---
M testdata/bin/kill-hbase.sh
1 file changed, 5 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/57/14757/1
--
To view, visit http://gerrit.cloudera.org:8080/14757
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Icef3d30e6b539a175e03f63fcdbfb2d4608c08fa
Gerrit-Change-Number: 14757
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
[Impala-ASF-CR] IMPALA-9165: Hack to remove MasterProcWALs directory in kill-hbase.sh
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14757 )
Change subject: IMPALA-9165: Hack to remove MasterProcWALs directory in kill-hbase.sh
......................................................................
IMPALA-9165: Hack to remove MasterProcWALs directory in kill-hbase.sh
Some jobs have been hanging in the testdata/bin/create-hbase.sh
script. Logs during the hang show the HBase Master is stuck
unitialized:
Master startup cannot progress, in holding-pattern until region onlined.
...
ERROR master.HMaster: Master failed to complete initialization after 900000ms.
Anecdotally, the HBase Master doesn't have this problem if we remove
the /hbase/MasterProcWALs directory in kill-hbase.sh. This patch
does exactly that. It is a hack, and we should update this code
once we know what is going on.
Testing:
- test-with-docker.py fails without this patch and passes with it
- Hand testing on my minicluster shows that this allows HBase to
restart and be consistently usable
Change-Id: Icef3d30e6b539a175e03f63fcdbfb2d4608c08fa
Reviewed-on: http://gerrit.cloudera.org:8080/14757
Reviewed-by: Joe McDonnell <jo...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M testdata/bin/kill-hbase.sh
1 file changed, 5 insertions(+), 0 deletions(-)
Approvals:
Joe McDonnell: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/14757
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Icef3d30e6b539a175e03f63fcdbfb2d4608c08fa
Gerrit-Change-Number: 14757
Gerrit-PatchSet: 3
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-9165: Hack to remove MasterProcWALs directory in kill-hbase.sh
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14757 )
Change subject: IMPALA-9165: Hack to remove MasterProcWALs directory in kill-hbase.sh
......................................................................
Patch Set 1:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5266/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/14757
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icef3d30e6b539a175e03f63fcdbfb2d4608c08fa
Gerrit-Change-Number: 14757
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 21 Nov 2019 15:46:30 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9165: Hack to remove MasterProcWALs directory in kill-hbase.sh
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14757 )
Change subject: IMPALA-9165: Hack to remove MasterProcWALs directory in kill-hbase.sh
......................................................................
Patch Set 1: Code-Review+2
This seems better than the hangs for the moment TBH
--
To view, visit http://gerrit.cloudera.org:8080/14757
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icef3d30e6b539a175e03f63fcdbfb2d4608c08fa
Gerrit-Change-Number: 14757
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 21 Nov 2019 08:33:52 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9165: Hack to remove MasterProcWALs directory in kill-hbase.sh
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Hello Tim Armstrong, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/14757
to look at the new patch set (#2).
Change subject: IMPALA-9165: Hack to remove MasterProcWALs directory in kill-hbase.sh
......................................................................
IMPALA-9165: Hack to remove MasterProcWALs directory in kill-hbase.sh
Some jobs have been hanging in the testdata/bin/create-hbase.sh
script. Logs during the hang show the HBase Master is stuck
unitialized:
Master startup cannot progress, in holding-pattern until region onlined.
...
ERROR master.HMaster: Master failed to complete initialization after 900000ms.
Anecdotally, the HBase Master doesn't have this problem if we remove
the /hbase/MasterProcWALs directory in kill-hbase.sh. This patch
does exactly that. It is a hack, and we should update this code
once we know what is going on.
Testing:
- test-with-docker.py fails without this patch and passes with it
- Hand testing on my minicluster shows that this allows HBase to
restart and be consistently usable
Change-Id: Icef3d30e6b539a175e03f63fcdbfb2d4608c08fa
---
M testdata/bin/kill-hbase.sh
1 file changed, 5 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/57/14757/2
--
To view, visit http://gerrit.cloudera.org:8080/14757
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Icef3d30e6b539a175e03f63fcdbfb2d4608c08fa
Gerrit-Change-Number: 14757
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-9165: Hack to remove MasterProcWALs directory in kill-hbase.sh
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14757 )
Change subject: IMPALA-9165: Hack to remove MasterProcWALs directory in kill-hbase.sh
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/14757
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icef3d30e6b539a175e03f63fcdbfb2d4608c08fa
Gerrit-Change-Number: 14757
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 21 Nov 2019 22:43:56 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9165: Hack to remove MasterProcWALs directory in kill-hbase.sh
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/14757 )
Change subject: IMPALA-9165: Hack to remove MasterProcWALs directory in kill-hbase.sh
......................................................................
Patch Set 2: Code-Review+2
Forgot to include the " || true" in the first upload. This fixes that. Carrying +2
--
To view, visit http://gerrit.cloudera.org:8080/14757
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icef3d30e6b539a175e03f63fcdbfb2d4608c08fa
Gerrit-Change-Number: 14757
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 21 Nov 2019 18:08:11 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9165: Hack to remove MasterProcWALs directory in kill-hbase.sh
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14757 )
Change subject: IMPALA-9165: Hack to remove MasterProcWALs directory in kill-hbase.sh
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/5100/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/14757
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icef3d30e6b539a175e03f63fcdbfb2d4608c08fa
Gerrit-Change-Number: 14757
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 21 Nov 2019 18:52:16 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9165: Hack to remove MasterProcWALs directory in kill-hbase.sh
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/14757 )
Change subject: IMPALA-9165: Hack to remove MasterProcWALs directory in kill-hbase.sh
......................................................................
Patch Set 1:
I'm not convinced we should merge this, but I'm putting this up as an option.
--
To view, visit http://gerrit.cloudera.org:8080/14757
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icef3d30e6b539a175e03f63fcdbfb2d4608c08fa
Gerrit-Change-Number: 14757
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Wed, 20 Nov 2019 22:27:37 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9165: Hack to remove MasterProcWALs directory in kill-hbase.sh
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14757 )
Change subject: IMPALA-9165: Hack to remove MasterProcWALs directory in kill-hbase.sh
......................................................................
Patch Set 1: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/5266/
--
To view, visit http://gerrit.cloudera.org:8080/14757
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icef3d30e6b539a175e03f63fcdbfb2d4608c08fa
Gerrit-Change-Number: 14757
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 21 Nov 2019 17:20:46 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9165: Hack to remove MasterProcWALs directory in kill-hbase.sh
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14757 )
Change subject: IMPALA-9165: Hack to remove MasterProcWALs directory in kill-hbase.sh
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/5091/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/14757
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icef3d30e6b539a175e03f63fcdbfb2d4608c08fa
Gerrit-Change-Number: 14757
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Wed, 20 Nov 2019 23:10:03 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9165: Hack to remove MasterProcWALs directory in kill-hbase.sh
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14757 )
Change subject: IMPALA-9165: Hack to remove MasterProcWALs directory in kill-hbase.sh
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5268/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/14757
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icef3d30e6b539a175e03f63fcdbfb2d4608c08fa
Gerrit-Change-Number: 14757
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 21 Nov 2019 18:08:36 +0000
Gerrit-HasComments: No