[jira] [Commented] (FLINK-2604) Access to SessionID without holding lock in ZooKeeperLeaderElectionService

["Till Rohrmann (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-2604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14726916#comment-14726916 ] 

Till Rohrmann commented on FLINK-2604:
--------------------------------------

This is not a problem, since all other writing access happen after a {{leaderLatch.hasLeadership()}} or as part of the {{LeaderLatchListener}} callback {{isLeader}}. Since the leader latch is closed first before assigning the {{null}} values to the variables, the call {{hasLeadership()}} will always be false.

> Access to SessionID without holding lock in ZooKeeperLeaderElectionService
> --------------------------------------------------------------------------
>
>                 Key: FLINK-2604
>                 URL: https://issues.apache.org/jira/browse/FLINK-2604
>             Project: Flink
>          Issue Type: Bug
>            Reporter: Ted Yu
>
> In stop() method of ZooKeeperLeaderElectionService :
> {code}
>                 confirmedLeaderSessionID = null;
>                 issuedLeaderSessionID = null;
> {code}
> In other part of the class, access to either of the above fields is guarded by synchronized (lock).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)