You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/04/13 08:27:29 UTC

[GitHub] [flink-kubernetes-operator] mbalassi commented on pull request #166: Flink 27211 deployments/finalizers missing for OpenShift Deployment

mbalassi commented on PR #166:
URL: https://github.com/apache/flink-kubernetes-operator/pull/166#issuecomment-1097705865

   @jbusche nit best practice: If you prefixs the PR msg with `[FLINK-XXXX]` then it gets automatically with the Jira issue, also I suggest to slightly modify the message to better describe the change:
   
   ```
   [Flink-27211] Adds deployments/finalizers for OpenShift Deployment 
   ```
   
   I am only giving you this level of feedback since it is your first PR to this repo, no need to modify this one, I will take it into account when merging - just helps us next time. Happy contributing! 😏 
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org