[jira] [Comment Edited] (THRIFT-4907) strong named assemblies wanted

["Jens Geyer (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/THRIFT-4907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16915092#comment-16915092 ] 

Jens Geyer edited comment on THRIFT-4907 at 8/24/19 9:11 PM:
-------------------------------------------------------------

[~Falco20019] could you elaborate on the why? Is that some company policy or what is the reason? Why exactly do we need a strong name, and why is it a blocker?


was (Author: jensg):
[~Falco20019] could you elaborate on the why? Is that some company policy or what is the reason? Why exactly do we need a strong name?

> strong named assemblies wanted
> ------------------------------
>
>                 Key: THRIFT-4907
>                 URL: https://issues.apache.org/jira/browse/THRIFT-4907
>             Project: Thrift
>          Issue Type: Bug
>          Components: C# - Library, netcore - Library, netstd - Library
>    Affects Versions: 0.12.0
>            Reporter: Benjamin Kraemer
>            Assignee: Jens Geyer
>            Priority: Blocker
>             Fix For: 0.13.0
>
>
> In THRIFT-2947, a strong name should have been added to [https://www.nuget.org/packages/ApacheThrift/0.12.0.1]
> Looking at the DLL, it's not signed at all. The assembly name is still `Thrift, Version=0.12.0.0, Culture=neutral, PublicKeyToken=null` and therefore missing the `PublicKeyToken` part.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)